500977 - xpfe's autocomplete.xml should not depend on bug 232598

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 385622 [details] [diff] [review]
patch

>       <!-- state which indicates the current action being performed by the user.
>            Possible values are : none, typing, scrolling -->
>       <property name="userAction"
>                 onset="this.setAttribute('userAction', val); return val;"
>-                onget="return this.getAttribute('userAction');"/>
>+                onget="return this.getAttribute('userAction') || '';"/>
Nit: As far as I can tell, this attribute is always set before it is read, and is always set and compared to one of the three known values above, so that it's not necessary to "protect" it. If anything it should default to 'none'.

>-                         this.param.getAttribute("autocompletesearchparam"),
>+                         this.param.getAttribute("autocompletesearchparam") || "",
Nit: I couldn't find anywhere that depended on an empty string; autocomplete searches either expect a valid (non-empty) search param or don't care. But I guess this one can ride since you fixed it in toolkit.

Comment 3

[Dão Gottwald [:dao]]

Ok, I've reverted the userAction change...

http://hg.mozilla.org/mozilla-central/rev/4f98563118d9

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/480ff1057204
xpfe's autocomplete.xml should not depend on bug 232598. r=neil