Closed Bug 500977 Opened 11 years ago Closed 11 years ago

xpfe's autocomplete.xml should not depend on bug 232598

Categories

(Core :: General, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Attachment #385622 - Flags: review?(neil)
Comment on attachment 385622 [details] [diff] [review]
patch

>       <!-- state which indicates the current action being performed by the user.
>            Possible values are : none, typing, scrolling -->
>       <property name="userAction"
>                 onset="this.setAttribute('userAction', val); return val;"
>-                onget="return this.getAttribute('userAction');"/>
>+                onget="return this.getAttribute('userAction') || '';"/>
Nit: As far as I can tell, this attribute is always set before it is read, and is always set and compared to one of the three known values above, so that it's not necessary to "protect" it. If anything it should default to 'none'.

>-                         this.param.getAttribute("autocompletesearchparam"),
>+                         this.param.getAttribute("autocompletesearchparam") || "",
Nit: I couldn't find anywhere that depended on an empty string; autocomplete searches either expect a valid (non-empty) search param or don't care. But I guess this one can ride since you fixed it in toolkit.
Attachment #385622 - Flags: review?(neil) → review+
Ok, I've reverted the userAction change...

http://hg.mozilla.org/mozilla-central/rev/4f98563118d9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/480ff1057204
xpfe's autocomplete.xml should not depend on bug 232598. r=neil
You need to log in before you can comment on or make changes to this bug.