500978 - Download Manager treats search terms as regular expressions

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Dão Gottwald [:dao]]

The text entered in the DM search field is interpreted as a regular expression. That seems unintentional and may result in unexpected results, e.g. the preriod in ".foobar" won't look for a period but any character.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 385625 [details] [diff] [review]
patch

Can we get a test for this too please?  Should be pretty easy to copy something from http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/tests/chrome/test_multiword_search.xul

r=sdwilsh with a test

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fd0b25ac9f0d

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 385625 [details] [diff] [review]
patch

a1912=beltzner please also check in the test

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/89d6990ea425

Comment 6

[juan becerra [:juanb]]

Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

In my profile I had downloaded a file "healthwellness.xls", in 3.5 searching for ".ness" would match that file, but 3.5.2 did not.