Closed Bug 500978 Opened 15 years ago Closed 15 years ago

Download Manager treats search terms as regular expressions

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Version:
1.9.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1
Tracking Flags:
Tracking Status
status1.9.1 --- .2-fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: perf, verified1.9.1)

Attachments

(1 file)

patch
882 bytes, patch
sdwilsh
: review+
beltzner
: approval1.9.1.2+
Details | Diff | Splinter Review 
The text entered in the DM search field is interpreted as a regular expression. That seems unintentional and may result in unexpected results, e.g. the preriod in ".foobar" won't look for a period but any character.
Flags: wanted1.9.1.x?
Attached patch patch — — Splinter Review 

        Attachment #385625 -
        Flags: review?(sdwilsh)

        Attachment #385625 -
        Flags: review?(sdwilsh) → review+

    
    

    
  
Comment on attachment 385625 [details] [diff] [review]
patch

Can we get a test for this too please?  Should be pretty easy to copy something from http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/tests/chrome/test_multiword_search.xul

r=sdwilsh with a test

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/fd0b25ac9f0d
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1

    
  

        Attachment #385625 -
        Flags: approval1.9.1.1?

    
  
Flags: wanted1.9.1.x?

    
  

        Attachment #385625 -
        Flags: approval1.9.1.1? → approval1.9.1.2?

    
    

    
  
Comment on attachment 385625 [details] [diff] [review]
patch

a1912=beltzner please also check in the test

        Attachment #385625 -
        Flags: approval1.9.1.2? → approval1.9.1.2+

    
  
Keywords: checkin-needed

    
    

    
  
Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

In my profile I had downloaded a file "healthwellness.xls", in 3.5 searching for ".ness" would match that file, but 3.5.2 did not.
Keywords: verified1.9.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: