Last Comment Bug 501106 - [HTML5] Implement Comment end bang state
: [HTML5] Implement Comment end bang state
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Henri Sivonen (:hsivonen)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-29 06:04 PDT by Henri Sivonen (:hsivonen)
Modified: 2009-07-15 04:37 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Implement comment end bang and comment end space states (56.09 KB, patch)
2009-07-03 07:58 PDT, Henri Sivonen (:hsivonen)
no flags Details | Diff | Review

Description Henri Sivonen (:hsivonen) 2009-06-29 06:04:58 PDT
http://www.whatwg.org/specs/web-apps/current-work/#comment-end-bang-state

This state missed the landing. It's important to get it in ASAP to enable testing.
Comment 1 Henri Sivonen (:hsivonen) 2009-07-03 07:58:42 PDT
Created attachment 386724 [details] [diff] [review]
Implement comment end bang and comment end space states

Note that there are also changes related to error reporting with < in various places in attributes. These changes should all be no-ops in C++.

There are also various whitespace changes in the .java file.
Comment 2 Jonas Sicking (:sicking) PTO Until July 5th 2009-07-13 16:13:12 PDT
Comment on attachment 386724 [details] [diff] [review]
Implement comment end bang and comment end space states

Given that neither me or blake really reviewed the generated code yet, lets just check this in with rs=sicking (rs meaning rubber stamp). We'll need to go through it in detail later before turning the parser on by default.
Comment 3 Henri Sivonen (:hsivonen) 2009-07-15 04:37:23 PDT
http://hg.mozilla.org/mozilla-central/rev/f4f94ee39e4b

Note You need to log in before you can comment on or make changes to this bug.