501285 - Really slow videos (1.8 frames/week) are boring to watch...

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Attachment: testcase

...and also cause us to attempt huge allocations:

(gdb) p mFramerate
$8 = 3.05174854e-06
...
822	  if (needSilence) {
823	    // Write silence to keep audio clock moving for av sync
824	    size_t count = mAudioChannels * mAudioRate * mCallbackPeriod;
825	    // count must be evenly divisble by number of channels.
826	    count = mAudioChannels * PRInt32(NS_ceil(mAudioRate*mCallbackPeriod));
827	    float* data = frame->mAudioData.AppendElements(count);
(gdb) p count
$28 = 327680992

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: testcase 2 (1.06 frames/year)

Comment 2

[Matthew Gregan [:kinetik]]

Forgot to note: this could be a dupe of bug 501289, depending on how we decide to fix it.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Is this fixed in Firefox 4 by the new decoder backend?

Comment 4

[Matthew Gregan [:kinetik]]

Yes, in that the specific problem code no longer exists, and the new code doesn't seem to suffer the same bug.  There might be other bugs related to very small or large frame durations (e.g. this bug and bug 501289), but let's mark this one as fixed.