Status

()

Core
SVG
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
I was looking through the SMIL code and saw an inefficient implementation of CalcBezier(). This patch eliminates the call to pow() and reduces the number of multiplications from 4 to 3.
(Assignee)

Comment 1

9 years ago
Created attachment 386067 [details] [diff] [review]
Optimize nsSMILKeySpline::CalcBezier
Attachment #386067 - Flags: review?(dholbert)
Attachment #386067 - Flags: review?(dholbert) → review+
Comment on attachment 386067 [details] [diff] [review]
Optimize nsSMILKeySpline::CalcBezier

Looks like you're just factoring out some "aT" multiplicands, to reduce the total number of multiplications -- looks good to me.

(You may also need review from an SVG peer, though -- jwatt, longsonr, or roc)
(Assignee)

Updated

9 years ago
Attachment #386067 - Flags: review?(jwatt)
(Assignee)

Updated

9 years ago
Attachment #386067 - Flags: review?(jwatt) → review?(longsonr)
Attachment #386067 - Flags: review?(longsonr) → review+
Assignee: nobody → jmuizelaar
Jeff landed this bug's patch earlier today.  Resolving.
http://hg.mozilla.org/mozilla-central/rev/585d2a1d511c
OS: Mac OS X → All
Hardware: x86 → All
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.