501557 - Sidebar right-click context menu is broken (extended menu, no navigation options, error in console)

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect)

Description

[u88484]

The sidebar context menu is broken when a page is loaded into the sidebar.  On first right-click, an extended menu with every possible context-menu option is shown.  Other clicks do not have the navigation options.  Clicking view source results in: 

Error: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIRequest.name]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: file:///C:/Junk/Mozilla%20Firefox/components/nsLoginManager.js :: anonymous :: line 328"  data: no]
Source File: file:///C:/Junk/Mozilla%20Firefox/components/nsLoginManager.js
Line: 328

STR:
0) Start a fresh copy of Firefox (has to be like this so right-click has been used yet)
1) Bookmark above url
2) right-click on bookmark -> properties, set bookmark to open in sidebar
3) click on bookmark in the bookmarks menu
4) right click on loaded page in sidebar, notice extended menu
5) dismiss menu and invoke it again, notice navigation options missing
6) dismiss and right click on the blue are next to the sign in input fields, regular context menu shows correctly

Comment 1

[Teo V.]

When I tried on my machine (win2k SP4Free), the navigation items in the context
menu in/for the sidebar (Back/Forward/Update/Stop) do not work, but appear
enabled (i.e. not greyed out).
The remaining items (add bookmark, save page as..., send link, mark everything,
view source code & view page info) work as they should from what I can see.
I don't see any errors in the JavaScript console.
HOW to replicate:
1) Select a random page.
2) Bookmark it.
3) Edit the bookmarks properties, and tick the 'open in side bar' box.
4) Open the page in the sidebar, and try the navigation items in the context
menu.

Comment 2

[Alice0775 White]

See Bug 483919 also.

Comment 3

[Teo V.]

See comment #3 of Bug 483919.

Bug remains as of FF 3.5.2.

Comment 4

[Michael Ryan]

The linked testcase is dead. Can you find another page that this happens on?

Comment 5

[Teo V.]

Answer to Comment #4:

As far as I have been able to test, the bug persists on any page that you open in the sidebar, regardless of where it is, and navigation items (reload, forward, stop and back) are enabled but do not work at all.

Comment 6

[Michael Ryan]

The bug in comment #0 is totally different than the bug in comment #1, as far as I can see. I used to be able to reproduce the bug in comment #0, but since the link is dead, I can no longer.

Comment 7

[Teo V.]

This bug was submitted after a discussion on #Firefox at the mozilla irc network, and although I can't recall the specifics of the discussion, I do recall that the original submitter of the bug and me agreed that we were seeing two different symptoms of the same bug. And in light of comment #2, Bug #483919 might be yet another symptom of the bug. Wonder if there is a way to merge these reports?

Comment 8

[Teo V.]

Added the code suggested in bug #483919, comment #2, but instead of replacing the existing code, I appended the code suggested in comment #2 it to the existing, like this (see comments):

  <commandset id="mainCommandset">
    <!-- Begin existing code -->
    <command id="Browser:Back"
             oncommand="getPanelBrowser().webNavigation.goBack();"
             disabled="true"/>
    <command id="Browser:Forward"
             oncommand="getPanelBrowser().webNavigation.goForward();"
             disabled="true"/>
    <command id="Browser:Stop" oncommand="PanelBrowserStop();"/>
    <command id="Browser:Reload" oncommand="PanelBrowserReload();"/>
    <!-- End existing code -->
    <!-- Begin comment #2 suggested code -->
    <command id="Browser:BackOrBackDuplicate"
             oncommand="getPanelBrowser().webNavigation.goBack(event);"
             disabled="true">
      <observes element="Browser:Back" attribute="disabled"/>
    </command>
    <command id="Browser:ForwardOrForwardDuplicate"
             oncommand="getPanelBrowser().webNavigation.goForward(event);"
             disabled="true">
      <observes element="Browser:Forward" attribute="disabled"/>
    </command>
    <command id="Browser:ReloadOrDuplicate"
             oncommand="PanelBrowserReload(event)"
             disabled="true">
      <observes element="Browser:Reload" attribute="disabled"/>
    </command>
    <!-- End comment #2 suggested code -->
  </commandset>

My initial impression after the restart of Firefox (3.5.3 BTW) is that this resolves the problem with the sidebar menu items Back/Forward/Reload/Stop not working as they should, though I have only verified Back and Reload at the point of writing this comment.

I kindly request that others with the possibility to do so try it and verify that the fix does what it should, and doesn't have any unforeseen effects. 
I am a total newbie with contributing to Firefox, so I don't have the said expertise to do all the necessary test.

PS: Remember to remove the comments I included above should this (potential) fix
make it to the next update.
Crossing my fingers, rubbing my rabbit's paw, looking for four-leaf clovers etc...

Comment 9

[Teo V.]

PS:
  Forgot location for fix:
   %Firefox%/chrome/browser.jar : content/browser/web-panels.xul

Comment 10

[u88484]

Teo, you should create a patch, attach it to this bug and then ask for review.  That would speed up the process a heck of a lot faster then pasting code here.

Comment 11

[Teo V.]

Attachment: Browser.jar, with content/browser/web-panels.xul modified as described by me in comment #8 and #9

Browser.jar, with content/browser/web-panels.xul modified as described by me in comment #8 and #9

Comment 12

[u88484]

(In reply to comment #11)
> Created an attachment (id=402396) [details]
> Browser.jar, with content/browser/web-panels.xul modified as described by me in
> comment #8 and #9
> Browser.jar, with content/browser/web-panels.xul modified as described by me in
> comment #8 and #9

I can't open up zips at work to see if you need to do anything else but the diff has to be a text file.

Comment 13

[Teo V.]

Attachment: web-panels.xul from browser.jar

web-panels.xul from browser.jar

Can't do diff because of some issues on my machine.

Comment 14

[Teo V.]

Have done some more testing, and over all, all functions seem to work (Back/Forward/Stop/Reload) as they should. However, there appears to be a slight glitch or two:

1: If one has clicked on links in the sidebar which open in it (not main window), then does a File->Print Preview, the sidebar reloads with the sidebar one initially opened (I open them from my bookmarks). I regard this as an annoyance factor, and not critical, but how about you guys (and gals)?

2: I have once experiences that the sidebar gets stuck, and can't be closed. IIRC, the workaround was simply to open something else in the sidebar, then close.

Comment 15

[Teo V.]

Have used the above modifications for each version up until the current one (3.5.6.), manually editing the appropriate file because each update reverts to the broken web-panels.xul.
So far, the only error I've seen is the one described in #1, which is nothing more than a nuisance factor for me (not perfect, but I can live with it).
And frankly, I'm getting a little tired fixing this each time there's and update, so why not fix this and put it to rest?

Comment 16

[Teo V.]

Oopsie -- #1 in comment #15...

Comment 17

[:Gijs (he/him)]

Not enough details here to really reproduce this, so going to assume it's gone away since it got filed 9 years ago...