501639 - Firefox suggests "attachment.cgi" instead of real attachment filename when downloading (due to content-disposition)

Status: RESOLVED DUPLICATE of bug 366219

(Bugzilla :: Attachments & Requests, defect)

Description

[Vitaliy Filippov]

User-Agent:       Opera/9.80 (X11; Linux i686; U; en) Presto/2.2.15 Version/10.00
Build Identifier: 

Content-Disposition: 'inline' or 'attachment' must be chosen according to file type.
For text/* and image/* it could be inline, but for all others it must be attachment, because if it's inline, Firefox suggests "attachment.cgi" instead of real attachment filename when downloading.

Reproducible: Always

Steps to Reproduce:
1. Add an attachment of some type not displayable in the browser
2. Try to download it using Firefox and 'save link as...'

Actual Results:  
Firefox will suggest "attachment.cgi" as the file name.

Expected Results:  
It must be the real attachment filename to be suggested.

A patch is included.

Comment 1

[Vitaliy Filippov]

Attachment: A patch guessing inline or attachment

Comment 2

[Frédéric Buclin]

Comment on attachment 386252 [details] [diff] [review]
A patch guessing inline or attachment

The patch is incorrect, and that's the job of Firefox to handle attachments correctly based on their MIME type.