501657 - xulrunner-1.9.1 will fail to build if system ply <2.5 is found

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jory A. Pratt [:anarchy]]

Attachment: force bundled ply for all builds

Build error:
/usr/lib64/python2.6/site-packages/ply/yacc.py:70: DeprecationWarning: the md5
module is deprecated; use hashlib instead
  import re, types, sys, cStringIO, md5, os.path
./qsgen.py:135: DeprecationWarning: the sets module is deprecated
  import sets
Traceback (most recent call last):
  File "./qsgen.py", line 1487, in <module>
    main()
  File "./qsgen.py", line 1469, in main
    traceable=options.enable_traceables)
  File "./qsgen.py", line 281, in readConfigFile
    parser = xpidl.IDLParser(cachedir)
  File
"/xulrunner-1.9.1/work/mozilla-1.9.1/xpcom/idl-parser/xpidl.py",
line 1217, in __init__
    optimize=1)
TypeError: lex() got an unexpected keyword argument 'outputdir'


Patch creator and gentoo bug info included in patch.

Comment 1

[Benjamin Smedberg]

Attachment: Insert at the beginning using our standard mechanism, rev. 2

Can you check that this works? Now that we have pythonpath.py we should just use that instead of assuming the relative location of xpcom/xpidl.py and other-licenses/ply

Comment 2

[Jory A. Pratt [:anarchy]]

(In reply to comment #1)
> Created an attachment (id=386991) [details]
> Insert at the beginning using our standard mechanism, rev. 2
> 
> Can you check that this works? Now that we have pythonpath.py we should just
> use that instead of assuming the relative location of xpcom/xpidl.py and
> other-licenses/ply

It will be later tonight that I check this. I will let ya know by tomorrow morning as to weather or not this works. It looks good to me, will double check to make sure as always tho.

Comment 3

[Jory A. Pratt [:anarchy]]

(In reply to comment #1)
> Created an attachment (id=386991) [details]
> Insert at the beginning using our standard mechanism, rev. 2
> 
> Can you check that this works? Now that we have pythonpath.py we should just
> use that instead of assuming the relative location of xpcom/xpidl.py and
> other-licenses/ply

Tested, works as intended.

Comment 4

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/9fa23a1803c0

Comment 5

[Benjamin Smedberg]

Comment on attachment 386991 [details] [diff] [review]
Insert at the beginning using our standard mechanism, rev. 2

I'll count that as r+. Requesting approval so that linux machines which have ancient system PLY can build Firefox, very low risk.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 386991 [details] [diff] [review]
Insert at the beginning using our standard mechanism, rev. 2

a1912=beltzner

Comment 7

[Benjamin Smedberg]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0ca2f203b8b0 and picked up http://hg.mozilla.org/releases/mozilla-1.9.1/rev/290b443109e1 because we hadn't ported pythonpath.py to the branch

Comment 8

[u279076]

What is the best/simplest way for QA to verify this on 3.5.2?

Comment 9

[Benjamin Smedberg]

I'm not sure why you care... it's a build bug, not a product bug.