501659 - HTML table's isRowSelected/isColumnSelected shouldn't fail if row or column has cell holes

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 406648 [details] [diff] [review]
patch

r=me with nits:

>+  return (row == -1 || *aColumn == -1) ? NS_ERROR_INVALID_ARG : NS_OK;

Why not check for < 0?

> NS_IMETHODIMP
> nsHTMLTableAccessible::IsCellSelected(PRInt32 aRow, PRInt32 aColumn,
>                                       PRBool *aIsSelected)
> {

<snip>

>   return rv;

Probably want to return NS_OK here too.

>+      // table instane

Nit: typo (-t)  :)

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> (From update of attachment 406648 [details] [diff] [review])
> r=me with nits:
> 
> >+  return (row == -1 || *aColumn == -1) ? NS_ERROR_INVALID_ARG : NS_OK;
> 
> Why not check for < 0?

if you prefer :) They are initialized by -1. They can be non negative or -1. No other values.

Comment 4

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/b6ce00fade5e

Comment 5

[Marco Zehe (:MarcoZ)]

Do we need this one for our tables for 3.6 round?

Comment 6

[alexander :surkov (:asurkov)]

Comment on attachment 406648 [details] [diff] [review]
patch

(In reply to comment #5)
> Do we need this one for our tables for 3.6 round?

Definitely. We want to have all table-related work on 1.9.2

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 406648 [details] [diff] [review]
patch

a192=beltzner

Comment 8

[alexander :surkov (:asurkov)]

landed on 1.9.2 - http://hg.mozilla.org/releases/mozilla-1.9.2/rev/d0c3beeec523

Comment 9

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b2pre) Gecko/20091029 Namoroka/3.6b2pre (.NET CLR 3.5.30729)