HTML table's isRowSelected/isColumnSelected shouldn't fail if row or column has cell holes

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access, verified1.9.2})

unspecified
access, verified1.9.2
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(status1.9.2 beta2-fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

9 years ago
Created attachment 406648 [details] [diff] [review]
patch
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #406648 - Flags: review?(bolterbugz)
Comment on attachment 406648 [details] [diff] [review]
patch

r=me with nits:

>+  return (row == -1 || *aColumn == -1) ? NS_ERROR_INVALID_ARG : NS_OK;

Why not check for < 0?

> NS_IMETHODIMP
> nsHTMLTableAccessible::IsCellSelected(PRInt32 aRow, PRInt32 aColumn,
>                                       PRBool *aIsSelected)
> {

<snip>

>   return rv;

Probably want to return NS_OK here too.

>+      // table instane

Nit: typo (-t)  :)
Attachment #406648 - Flags: review?(bolterbugz) → review+
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> (From update of attachment 406648 [details] [diff] [review])
> r=me with nits:
> 
> >+  return (row == -1 || *aColumn == -1) ? NS_ERROR_INVALID_ARG : NS_OK;
> 
> Why not check for < 0?

if you prefer :) They are initialized by -1. They can be non negative or -1. No other values.
(Assignee)

Comment 4

9 years ago
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/b6ce00fade5e
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 5

9 years ago
Do we need this one for our tables for 3.6 round?
(Assignee)

Comment 6

9 years ago
Comment on attachment 406648 [details] [diff] [review]
patch

(In reply to comment #5)
> Do we need this one for our tables for 3.6 round?

Definitely. We want to have all table-related work on 1.9.2
Attachment #406648 - Flags: approval1.9.2?
(Assignee)

Updated

9 years ago
Flags: in-testsuite+
Comment on attachment 406648 [details] [diff] [review]
patch

a192=beltzner
Attachment #406648 - Flags: approval1.9.2? → approval1.9.2+

Comment 9

9 years ago
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b2pre) Gecko/20091029 Namoroka/3.6b2pre (.NET CLR 3.5.30729)
status1.9.2: --- → final-fixed
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.