501725 - HTML5 parser uses nsDependentString() on strings that are not null terminated.

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Johnny Stenback (:jst)]

Attachment: Use nsDependentSubstring() instead.

I see a ton of these whenever I'm loading pages with the HTML5 parser enabled.

###!!! ASSERTION: nsTDependentString must wrap only null-terminated strings: 'mData[mLength] == 0', file ../../dist/include/nsTDependentString.h, line 67

Patch coming up.

Comment 1

[[e-mail]]

Comment on attachment 386303 [details] [diff] [review]
Use nsDependentSubstring() instead.

>+  return local->Equals(nsDependentSubstring(buf + offset, buf + offset + length));
Isn't Substring preferred over explict uses of nsDependentSubstring?

Comment 2

[Johnny Stenback (:jst)]

Fixed.

http://hg.mozilla.org/mozilla-central/rev/bd42b12e6d2e

Comment 3

[Johnny Stenback (:jst)]

(In reply to comment #1)
> (From update of attachment 386303 [details] [diff] [review])
> >+  return local->Equals(nsDependentSubstring(buf + offset, buf + offset + length));
> Isn't Substring preferred over explict uses of nsDependentSubstring?

Duh, totally overlooked this comment here. And I don't know if Substring is preferred here, if it is I'm happy to change it, but this file uses nsDependentSubstring() elsewhere too.