501963 - "We're building" rotating with "We believe"

Status: RESOLVED FIXED

(www.mozilla.org :: General, enhancement, P3)

Description

[tinawiel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9.0.11) Gecko/2009060308 Ubuntu/9.04 (jaunty) Firefox/3.0.11
Build Identifier: 

"We're building..." appears instead of "We believe..." every 5 sec (and vice versa). It supposed to look like smbd's typing it.

Reproducible: Always

Comment 1

[tinawiel]

Attachment: index-patch

Comment 2

[tinawiel]

Attachment: screen-patch

Comment 3

[tinawiel]

Attachment: mozilla.org.js-patch

Comment 4

[Reed Loden [:reed]]

Comment on attachment 386517 [details] [diff] [review]
index-patch

This isn't <noscript> safe. If we're going to use JavaScript for this, we need to always display something and then change it later. Showing nothing just means people with JS disabled won't see anything at all.

Comment 5

[David Boswell]

Comment on attachment 386520 [details] [diff] [review]
mozilla.org.js-patch

Reed, could you take a look over this patch before I check it in?  If anyone else more familiar with JS than I am wants to review this, feel free.

Comment 6

[Reed Loden [:reed]]

Comment on attachment 386520 [details] [diff] [review]
mozilla.org.js-patch

Also need to make this localizable besides my comments above.

Comment 7

[tinawiel]

Attachment: index.php.patch

the default value ('We believe') has been added. now it is safe for user with JS disabled.

Comment 8

[Reed Loden [:reed]]

Comment on attachment 387349 [details] [diff] [review]
index.php.patch

Shouldn't you give it an id at least, or are you saying the <span> inside the <h1> with id moral? Probably be best to just give the <span> an id.

Comment 9

[tinawiel]

Attachment: index.php

It is <noscript> safe. Text is localizable.

Comment 10

[tinawiel]

Attachment: mozilla.org.js

Comment 11

[fantasai]

Hi tinawiel, I'd change the index.php code so that
  a) the initial 'display' style is given via ID, not with an attribute
  b) the page makes sense when CSS is turned off, i.e. don't mush both sentences into one <h1> tag. Either use two <h1> tags or two <p> tags or something like that.
Other than that it looks pretty good. reed might have some other comments, I'm not too familiar with the js framework here.

Comment 12

[tinawiel]

It is a problem to show only one text with JS disabled and CSS disabled (ex: show 'We're building' but hide 'We believe' ) 
Is it okey to use <input type=hidden...> for this purpose? Or is it acceptable to show both "We're building" and "We believe" and the same time when JS and CSS  are disabled ?

Comment 13

[fantasai]

I think it makes sense to show both when CSS is off, with "We believe" placed before "We're building".

Comment 14

[tinawiel]

Attachment: index.php

Comment 15

[tinawiel]

Attachment: screen.css

Comment 16

[tinawiel]

Attachment: mozilla.org.js

This is <noscript> and no-CSS safe. Text is localizable.

Comment 17

[David Boswell]

Reed or fantasai, would one of you be able to review the latest set of patches for this?  Now that the new design is up, it would be good to get the rotation working.

Comment 18

[fantasai]

I'm not a JS person, so I don't claim to understand how
  $('#moral-one').css('display','block');
works, but assuming it does it all looks good to me. :) r=fantasai

Comment 19

[Reed Loden [:reed]]

Comment on attachment 387788 [details] [diff] [review]
index.php

This will display both "morals" at the same time if JS is off. Is that really what we want? How does the page look with both of them displayed?

Comment 20

[Reed Loden [:reed]]

Comment on attachment 387789 [details] [diff] [review]
screen.css

yeah, sure, r=reed

Comment 21

[Reed Loden [:reed]]

Comment on attachment 387790 [details] [diff] [review]
mozilla.org.js

waiting on an answer to my other comment before reviewing this... also need to get my testing environment back up to actually test it.

Comment 22

[David Boswell]

Re question #19, it would be helpful to have a screenshot to look at.  Reed, is that something you could post when your testing environment is back up?

Comment 23

[fantasai]

We can have one of them "display: none" via CSS, then let the JS rotate it from there.

Comment 24

[David Boswell]

We added this to the home page with the recent design refresh.