Closed
Bug 502025
Opened 15 years ago
Closed 15 years ago
Create and implement modules on the sidebar template for the new start page
Categories
(support.mozilla.org :: Knowledge Base Articles, task)
support.mozilla.org
Knowledge Base Articles
Tracking
(Not tracked)
VERIFIED
FIXED
1.3
People
(Reporter: paulc, Assigned: paulc)
References
()
Details
Attachments
(2 files)
3.14 KB,
patch
|
laura
:
review+
|
Details | Diff | Splinter Review |
1.52 KB,
patch
|
Details | Diff | Splinter Review |
Currently, the sidebar has the modules hard coded in (this was done for quick set up of the test). We need to allow the sidebar modules to be assigned from tiki-admin_modules.php
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #386747 -
Flags: review?(smirkingsisyphus)
Attachment #386747 -
Flags: review?(laura)
Assignee | ||
Comment 2•15 years ago
|
||
This is the content for the sidebar modules. You need to create the modules with the same name and assign them in the same order to theme=mozms2.css
Assignee | ||
Comment 3•15 years ago
|
||
This could even make it into 1.2.1 but I don't want to over-clutter it. David/Laura: what do you think?
Target Milestone: 1.4 → 1.3
Updated•15 years ago
|
Attachment #386747 -
Flags: review?(smirkingsisyphus)
Attachment #386747 -
Flags: review?(laura)
Attachment #386747 -
Flags: review+
Assignee | ||
Comment 4•15 years ago
|
||
r48082 / r48083 Waited to see it pushed. Here we go: https://support-stage.mozilla.org/en-US/kb/Home+page+new I also created the modules and assigned them properly on production, but no page to display them exists yet. We will need to create the template on production after push. Looking at: https://support.mozilla.com/tiki-theme_control_objects.php?offset=0&sort_mode=theme_desc Theme mozms2.css has been assigned to "Firefox Help 4" but the article has been deleted. We may want to delete this assignment or re-create the page for testing when time comes.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
(In reply to comment #4) > Looking at: > https://support.mozilla.com/tiki-theme_control_objects.php?offset=0&sort_mode=theme_desc > Theme mozms2.css has been assigned to "Firefox Help 4" but the article has been > deleted. We may want to delete this assignment or re-create the page for > testing when time comes. Assignment deleted. :-)
Comment 6•15 years ago
|
||
So, Chris, is this as good as verified? I've already tested this page for layout in another bug.
Comment 7•15 years ago
|
||
I don't know. How is this tested?
Assignee | ||
Comment 8•15 years ago
|
||
Pretty much make sure it looks as it did before. The change should only be apparent in the backend since we can now control the modules on the sidebar.
Comment 9•15 years ago
|
||
I created <https://support.mozilla.com/en-US/kb/bug+502025+test> in the sandbox, and assigned it to mozm2.css. I get two instances of each sidebar item. I can confirm that the modules "waysgethelp", "promotebox", and "wantgetinvolved" are assigned to mozms2.css at <https://support.mozilla.com/tiki-admin_modules.php?locale=en-US>. If I edit "waysgethelp", I can see the change in the second "Ways to get help" to get help box on <https://support.mozilla.com/en-US/kb/bug+502025+test>. When I do the same on support-stage, I can see the change on <https://support-stage.mozilla.org/en-US/kb/Firefox+Help+4>. We should also test the interface translator on this.
Assignee | ||
Comment 10•15 years ago
|
||
Since this hasn't been pushed to prod, what you're saying is expected. The old version had the sidebar modules hard coded at the top (we rolled it out quickly). Translation should work as with any other modules. You may test on stage.
Looks good on https://support-stage.mozilla.org/en-US/kb/Firefox+Help+4; what's there to test, regarding translation?
Verified FIXED; I'll keep an eye out for regressions.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•