502095 - "Write" popup menu and Today pane statusbar item have odd icons

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[David Ascher (:davida)]

Attachment: screenshot (mac)

See screenshot attachment

Comment 1

[Phil Ringnalda (:philor)]

Doesn't the owner of those icons live over in Calendar: Lightning Only land?

Comment 2

[Stefan Sitter [:ssitter]]

For reference: I see no issues using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.1pre) Gecko/20090702 Shredder/3.0b3pre with Lightning 1.0pre (BuildID: 2009070203171) and Thunderbird default theme.

Comment 3

[Martin Schröder [:mschroeder]]

Problem is that we copied over the -moz-image-region from the winstripe theme, but the small toolbar icons in the pinstripe theme are larger.

Comment 4

[Adil Allawi]

There are more problems on the Mac - the Today Pane status bar button has the wrong icon from chrome://calendar/skin/toolbar-small.png. Also, the Mac toolbar icons are too large for the Mac status bar so we need a new smaller icon just for the pinstripe theme.

And, on the right side of the button the chrome references icons that do not exist in pinstripe: chrome://global/skin/icons/collapse.png and chrome://global/skin/icons/expand.png.

Comment 5

[Decathlon]

(In reply to comment #4)
> There are more problems on the Mac - the Today Pane status bar button has the
> wrong icon from chrome://calendar/skin/toolbar-small.png. Also, the Mac toolbar
> icons are too large for the Mac status bar so we need a new smaller icon just
> for the pinstripe theme.

In the patch for bug 393763 I've added an icon 16x16, Mac style, for the today button in the status bar. The icon is to the extreme right of the image toolbar-small.png 
https://bug393763.bugzilla.mozilla.org/attachment.cgi?id=443305
(see bug 393763 comment #15).
Obviously it's just a proposal because I've added it only for testing the patch attachment 443304 [details] [diff] [review] on Mac.

Comment 6

[Felix Möller]

There is no problem on Linux either, so this is Mac specific.

It can still be reproduced with todays daily 1.0.3 on my Mac.

Comment 7

[Felix Möller]

Attachment: screenshot of fixed icons

I got a built by Decathlon which works way better. Have a look at attached Screenshot.

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Decathlon, I assume you have a patch then?

Comment 9

[Decathlon]

Attachment: patch that needs improvement

(In reply to comment #8)
> Decathlon, I assume you have a patch then?

Yes, but as Felix pointed out in a mail the icons look scaled. In his screenshot they look like 16x16 pixles size, instead they should be 24x24 
http://mxr.mozilla.org/comm-central/source/calendar/base/themes/pinstripe/images/toolbar-small.png

Since I can't test on a Mac, I can't improve the patch.

Comment 10

[Felix Möller]

Attachment: screenshot of another menu without image scaling issues

Comment 11

[Felix Möller]

Attachment: icons in firefox

all icons on a mac seem to be 16px.

Here is a screenshot of Firefox. Not sure if the icons are scalled.

Comment 12

[Decathlon]

(In reply to comment #10)
> Created attachment 507828 [details]
> screenshot of another menu without image scaling issues

That icon is:
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/icons/server-remote-lock.png
and is a 16x16 icon, but it comes from Thunderbird code.

As far as I can see there aren't icons 16x16 in the theme/pinstripe directory.
Both toolbar images
http://mxr.mozilla.org/comm-central/source/calendar/base/themes/pinstripe/images/toolbar-small.png
http://mxr.mozilla.org/comm-central/source/calendar/base/themes/pinstripe/images/toolbar-large.png
have icons 24x24 and 32x32.

Maybe we should steal two 16px icons (new event and new task) from the winstripe theme and add them to the toolbar-small.png image in the pinstripe theme.

Comment 13

[Philipp Kewisch [:Fallen][☁️📆]]

(In reply to comment #12)
> Maybe we should steal two 16px icons (new event and new task) from the
> winstripe theme and add them to the toolbar-small.png image in the pinstripe
> theme.
Sounds like the right solution to me.

Comment 14

[Felix Möller]

Attachment: screenshot of fixed icons

Decathlon has created a new patch and sent me a build which works perfectly. Have a look at attached screenshot.

Comment 15

[Decathlon]

Attachment: patch - v1

(In reply to comment #14)
> Decathlon has created a new patch and sent me a build which works perfectly.
> Have a look at attached screenshot.

Let's try that then.
I've added two icon (new event and new task) 16px Mac Style to the image toolbar-small.png in the pinstripe theme. 
Initially I thought to copy and paste the icon from the winstripe theme, at last I did a mix between the icons in the same image (base symbol Mac style) and the icons from the winstripe theme (the green "+" symbol over the icons). Maybe would be a good idea if someone with graphic skills could check those icons.

The first icon (write mail message) still belongs to the image mail-toolbar-small.png 
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/icons/mail-toolbar-small.png
that is Thunderbird's code and is 24x24 size hence it looks scaled, but the same happens for the winstripe theme that uses the same icon. Don't know if it needs a specific 16x16 icon.

Comment 16

[Decathlon]

I've just read the second part of comment #4
> And, on the right side of the button the chrome references icons that do not
> exist in pinstripe: chrome://global/skin/icons/collapse.png and
> chrome://global/skin/icons/expand.png

i.e. on the Mac is missing a part of the today pane button on the status bar. For comparison take a look at the screenshots about bug 393763:

Mac https://bug393763.bugzilla.mozilla.org/attachment.cgi?id=465963
Linux https://bug393763.bugzilla.mozilla.org/attachment.cgi?id=427593

I've searched inside comm-central/mozilla/toolkit/themes/pinstripe/ directory and it seems that don't exist icons equal to collapse.png and expand.png
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/winstripe/global/icons/collapse.png

Something similar could be found inside the "arrow" directory:
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/themes/pinstripe/global/arrow/
e.g. arrow-up-sharp.gif
     arrow-up.gif
but I don't know what's better for the pinstripe theme.

Comment 17

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 507999 [details] [diff] [review]
patch - v1

code looks good, lets take this and see how it goes!

Comment 18

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f79a7b3153fc>
-> FIXED

Comment 19

[Philipp Kewisch [:Fallen][☁️📆]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/e077e4c2f4fe>
a=philipp