502133 - F11 no longer leaves fullscreen mode

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Will Roberts [:bws42]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090701 Minefield/3.6a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090702 Minefield/3.6a1pre

F11 only seems to toggle between two (three?) different full screen modes now. The first shows a minimal version of the navigation and chrome, the second allows the minimal chrome to auto-hide, and the third looks more like the standard window but is missing the title bar and still covers the task bar.

Reproducible: Always

Steps to Reproduce:
1. Hit F11 to enter full screen mode.
2. Hit F11 to exit full screen mode.
Actual Results:  
Firefox remains in full screen mode.

Expected Results:  
Firefox exits full screen mode.

This is a regression from bug 484488.

Build based off ea19cebaa1ef works as expected, and build based off 8312b1fdc851 does not.

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ea19cebaa1ef&tochange=8312b1fdc851

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Same on Win7 RC, setting to New.

Comment 2

[Sylvain Pasche]

Affects all Windows versions (XP, Vista, Win7).

Comment 3

[Sylvain Pasche]

Could be affecting Linux too (bug 502232).

Comment 4

[Doug Turner (:dougt)]

try to look at it over the break, if not on tuesday.

ooc, does clicking on the minimize button in the upper right minimize the browser?

Comment 5

[Will Roberts [:bws42]]

(In reply to comment #4)
> try to look at it over the break, if not on tuesday.
> 
> ooc, does clicking on the minimize button in the upper right minimize the
> browser?

Yes it does, and the close button works as well. The restore button behaves like F11 does, pressing it once switches to the auto-hide version, and hitting it again switches to the more normal window, but without OS chrome.

Comment 6

[Doug Turner (:dougt)]

Attachment: patch v.1

use the correct sizemode flag when posting the event to the webshell window.

Comment 7

[Doug Turner (:dougt)]

posted to try; waiting results.

Comment 8

[Doug Turner (:dougt)]

builds: https://build.mozilla.org/tryserver-builds/[e-mail]-1246686861/

Hi Will / Jim,

Do you think you could try the above build?

Comment 9

[Sylvain Pasche]

The build fixes the issue, but there is another regression. When you leave fullscreen mode, the window is always in maximized state. (If you then unmaximize that window, it gets to its position before entering fullscreen).

Comment 10

[Doug Turner (:dougt)]

okay. good. I will take a look at that now Sylvain!

Comment 12

[Doug Turner (:dougt)]

new build posted to try; should have builds in about 2hrs.

Comment 13

[BUGabundo]

Doug is this it https://build.mozilla.org/tryserver-builds/[e-mail]-1246734864/ ?

Comment 14

[Bill Gianopoulos [:WG9s]]

OS -> All as this fails under Linux also, which probably means it is filed against the wrong component as well.

Comment 15

[Doug Turner (:dougt)]

Bugabundo, i think so, but the fix doesn't look complete.  i see it bouncing from normal to maximize after you use F11 to exit fullscreen mode.

Comment 16

[Doug Turner (:dougt)]

Hi again,
Could you take a look at this build?  I think it addresses windows, but am not sure about linux:

https://build.mozilla.org/tryserver-builds/[e-mail]-sizemode_1/

Comment 17

[Sylvain Pasche]

Hi Doug,
Unfortunately I'm not seeing improvements with this build. On Windows, the window is maximized after leaving full screen. On Linux, I can't get out of full screen (F11 or the unmaximize button has no effect) and the chrome isn't hidden once in full screen.

Maybe the wrong patch was used by the try server? I'm seeing a revision of 910b07444baf+ in about:buildconfig.

Comment 18

[Doug Turner (:dougt)]

marking fixed.  I have backed out 484488 and will try again later.

sorry for the trouble :-(

Comment 20

[Sylvain Pasche]

Could be nice to have a browser test that switches to fullscreen and checks the window positions in order to check we are getting back to the previous position when leaving fullscreen. That should hopefully catch such regressions.

Comment 21

[Doug Turner (:dougt)]

+1

Comment 22

[BUGabundo]

this is now fixed for me, using daily ubuntu Mozilla team PPA.

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)

Comment 24

[BUGabundo]

possibly related to bug 512575
https://bugzilla.mozilla.org/show_bug.cgi?id=512575