Closed
Bug 502279
Opened 16 years ago
Closed 15 years ago
Support for passing 64b arguments in JIT'd function calls
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tamarin Graveyard
Baseline JIT (CodegenLIR)
Tracking
(Not tracked)
VERIFIED
WONTFIX
Future
People
(Reporter: rreitmai, Assigned: rreitmai)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.42 KB,
patch
|
edwsmith
:
superreview+
|
Details | Diff | Splinter Review |
This work was part of the box initiative and was prep-work for support of 64b argument passing.
We don't yet fully support this mode on all platforms as this patch targets x86.
For other architectures the asm_arg() work done in Nativei386.cpp would need to be duplicated.
|
Assignee | |
Comment 1•16 years ago
|
||
Runs fine against 32b osx - testing on sandbox underway, will comment when complete.
Attachment #386763 -
Flags: superreview?(edwsmith)
|
|
Assignee | |
Comment 2•16 years ago
|
||
64b builds failing. I'll fixup and re-post patch, but most likely it will be a small change, so review of current patch is still needed please.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Decided to leave the constants for now since shuffling them isn't really needed , but kept all other changes.
Attachment #386763 -
Attachment is obsolete: true
Attachment #387090 -
Flags: superreview?(edwsmith)
Attachment #386763 -
Flags: superreview?(edwsmith)
|
||
Comment 4•16 years ago
|
||
Comment on attachment 387090 [details] [diff] [review]
ver 2 - trim down the changes
please comment out any new dead code... or add test cases and ports to the other cpu's
Attachment #387090 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Comment 5•15 years ago
|
||
status? what depends on this? the box prototype?
Blocks: 490565
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Future
|
|
Assignee | |
Comment 6•15 years ago
|
||
We can retire this bug; it was part of box prototype work and is now stale.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
|
||
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•