Closed
Bug 502447
Opened 17 years ago
Closed 17 years ago
style.overflow="hidden" followed by style.overflow="" fails to reshow scrollbars
Categories
(Core :: Layout, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: dao, Assigned: bzbarsky)
References
Details
(Keywords: regression, testcase)
Attachments
(2 files)
|
1.78 KB,
text/html
|
Details | |
|
3.61 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
See attached testcase. The first button sets the root element's style.overflow to "hidden", the second one to "". The scrollbar should reappear but doesn't, although the computed style correctly says "overflow: visible".
Works as expected on 1.9.1.
Flags: blocking1.9.2?
|
||
Comment 1•17 years ago
|
||
works: http://hg.mozilla.org/mozilla-central/rev/ff250122fa99
fails: http://hg.mozilla.org/mozilla-central/rev/ed38105c9c2a
range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ff250122fa99&tochange=ed38105c9c2a
Keywords: regressionwindow-wanted
|
|
Assignee | |
Comment 4•17 years ago
|
||
Note to self: the problem is that PropagateScrollToViewport sets the viewport's style override to the style of the frame we propagate from, but it happens when constructing frames for the <body>(!), except in debug builds (where it also happens in ConstructDocElementFrame, but after we did the scrollframe setup). This causes us to pick up the override style of "hidden" when constructing the scrollframe after the second button click, and hence not create any scrollbar frames.
|
|
Assignee | |
Comment 5•17 years ago
|
||
Attachment #390057 -
Flags: review?(roc)
Attachment #390057 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Flags: blocking1.9.2? → blocking1.9.2+
Priority: -- → P2
|
|
Assignee | |
Comment 7•17 years ago
|
||
This landed before the 1.9.2 branchpoint.
Keywords: fixed1.9.2
Target Milestone: --- → mozilla1.9.2a1
|
|
||
Updated•17 years ago
|
status1.9.2:
--- → beta1-fixed
Keywords: fixed1.9.2
You need to log in
before you can comment on or make changes to this bug.
Description
•