502537 - Tabpanels not rendered properly on some GTK themes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Michael Ventnor]

Attachment: Patch

We have a hacky way of drawing tabpanels to still look good, but on some themes that causes some problems. So what better way to solve it than an even hackier way to draw them? This is another problem revealed by the New Wave theme.

Such is life when our way of drawing tabs is different to GTK's.

Comment 1

[Julien "_FrnchFrgg_" RIVAUD]

What a relief we don't have to cater for the broken engines not obeying to clip
rects !

Comment 2

[Michael Ventnor]

(In reply to comment #1)
> What a relief we don't have to cater for the broken engines not obeying to clip
> rects !

If we can't rely on clip rects than that doesn't really leave us with any options...
Engines expose bugs in our code, if we expose bugs in an engine's code for it to be fixed then that's more for the better. The Moblin themer back at the Dublin hackfest was certainly thankful :-)

Comment 3

[Michael Ventnor]

And if there are engines out there that don't support the clip rects for tabpanels, the worst that happens is that the tabpanel is drawn twice. If the engine is bad enough to not support clipping then I doubt it would support translucent tabpanels.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/df54fd4ae7ad

Comment 5

[Julien "_FrnchFrgg_" RIVAUD]

Yeah, the problem is rather when the clipping isn't supported during the painting of the handles of the notebook, ie the tabs themselves. And all the engines I encountered that didn't obey clipping did so for every paint primitive. But each time it was considered a bug in the engine by their creators/maintainers so it's not that bad. (IIRC, human was plagued by that, but that was the only non-obscure engine that was)