502574 - Defunct loop in onTitleChanged

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[John P Baker]

Attachment: patch [Checked in: Comment 2 & 4]

onTitleChanged was changed in bug 179656 to reflect that the browser array and the tab array were no longer in step.

-            var tab = tabBrowser.mTabContainer.childNodes[i];
+            var tab = document.getAnonymousElementByAttribute(tabBrowser, "linkedpanel", this.parentNode.id);

but the loop that finds the browser index was not removed at the same time.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 386962 [details] [diff] [review]
patch
[Checked in: Comment 2 & 4]

Yay! I also fixed this in bug 402147 back in 2007, but that's still waiting for review...

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/263cbbfeda99

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 386962 [details] [diff] [review]
patch
[Checked in: Comment 2 & 4]

a1912=beltzner

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c950fbde88f2

Comment 5

[u279076]

What is the best/simplest way for QA to verify this on 3.5.2?

Comment 6

[Dão Gottwald [:dao]]

Open http://mxr.mozilla.org/mozilla1.9.1/source/browser/base/content/tabbrowser.xml and verify that the removed code isn't there anymore. Then load 
data:text/html,<script>setInterval(function(){document.title=Math.random()},200)</script> and verify that the tab's label updates continuously.

Comment 7

[u279076]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2)
Gecko/20090729 Firefox/3.5.2
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729
Firefox/3.5.2
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.2) Gecko/20090729
Firefox/3.5.2

Verified code removed on the above builds.
Verified tab label updates continuously on the above builds.
Verified1.9.1

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 with builds on all platforms like Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b3pre) Gecko/20091114 Namoroka/3.6b3pre ID:20091114033807