Closed Bug 502584 Opened 15 years ago Closed 15 years ago

Firefox will crash when visiting www.hp.com on sparc platform.

Categories

(Core :: JavaScript Engine, defect)

Sun
Solaris
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: leon.sha, Assigned: leon.sha)

References

()

Details

(Keywords: crash, verified1.9.1.1)

Attachments

(1 file)

Firefox will crash when visiting www.hp.com on Sparc platform.
Attached patch patchSplinter Review
The following code was generated for www.hp.com
..........
sethi    %hi(0xec847000), %l0 
bset     0x00000088, %l0        ! 0xec847088
sethi    %hi(0x1400), %l0
bset     0x000001fc, %l0        ! 0x15fc
st       %l0, [%i0 + %l0]
..........
Register %l0 was recovered by itself.
The reason here is that register L0 is used as a temporary register in a lot of micros. So when these macros are used, L0 should not be used any more. We need other temporary registers. So use L2 to replace L0 in NativeSparc.cpp.
Attachment #386970 - Flags: review?(gal)
Attachment #386970 - Flags: review?(gal) → review+
Keywords: fixed1.9.1
Keywords: fixed1.9.1.1
Leon, or anyone with sparc, can you verify this fix on trunk and a 1.9.1 nightly? 
Please change the status to verified and keyword to verified1.9.1.1 also.   Thanks.
Severity: normal → critical
Keywords: crash
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: