Build script for size report should not compile the shell or enable eval

VERIFIED FIXED in flash10.1

Status

VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: brbaker, Assigned: brbaker)

Tracking

unspecified
flash10.1
All
Windows XP
Bug Flags:
flashplayer-qrb +
flashplayer-triage +

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

9 years ago
The size report is meant to really just be the core of the VM so we should not be compiling with the shell enabled and we should also not enable eval as it is not a shipping feature.
Flags: flashplayer-triage+
Flags: flashplayer-qrb?

Updated

9 years ago
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Target Milestone: --- → flash10.1
(Assignee)

Comment 1

9 years ago
Created attachment 403781 [details] [diff] [review]
disable eval

Disable the eval feature when compiling for the size report. 

We must compile the shell since it is during the linking of the shell that we produce the .map file.
Attachment #403781 - Flags: review?(dschaffe)

Updated

9 years ago
Attachment #403781 - Flags: review?(dschaffe) → review+
(Assignee)

Comment 2

9 years ago
Comment on attachment 403781 [details] [diff] [review]
disable eval

pushed patch as 2638:19ab0ef28978
Attachment #403781 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.