Closed Bug 502607 Opened 15 years ago Closed 15 years ago

Build script for size report should not compile the shell or enable eval

Categories

(Tamarin Graveyard :: Build Config, defect)

Product:
Tamarin Graveyard
Component:
Build Config
Platform:
All
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: brbaker, Assigned: brbaker)

Details

Attachments

(1 obsolete file) 

The size report is meant to really just be the core of the VM so we should not be compiling with the shell enabled and we should also not enable eval as it is not a shipping feature.
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
Assignee: nobody → brbaker
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Target Milestone: --- → flash10.1
Attached patch disable eval (obsolete) — — Splinter Review 
Disable the eval feature when compiling for the size report. 

We must compile the shell since it is during the linking of the shell that we produce the .map file.
Attachment #403781 - Flags: review?(dschaffe)
Attachment #403781 - Flags: review?(dschaffe) → review+
Comment on attachment 403781 [details] [diff] [review]
disable eval

pushed patch as 2638:19ab0ef28978
Attachment #403781 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: