502634 - ipdlc cannot compile NPP.ipdl

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Benjamin Smedberg]

trying to compile NPP.ipdl:

  File "/builds/electrolysis/src/ipc/ipdl/ipdl/type.py", line 509, in visitMessageDecl
    if decl is not None and decl.type.isProtocol():
AttributeError: MessageType instance has no attribute 'isProtocol'

decl.type is None. I tried adding a null-check and it failed in a similar way with some type that didn't implement isProtocol. Since I'm not sure what I'm doing, I'm just going to file this and leave it for cjones.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I can't reproduce this.  Can you provide the exact command you ran?  I tried

  dom/plugins $ ../../ipc/ipdl/ipdlc NPP.ipdl

and that works fine.

Comment 2

[Benjamin Smedberg]

Hrm, this was with a fixed up patch from bug 502003

python ipc/ipdl/ipdl.py dom/plugins/NPP.ipdl dom/plugins/NPAPI.ipdl

Is it possible that compiling multiple protocols is causing problems somehow?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed
62eedc3a5f90 Chris Jones - bugs 502003, 502634: compile multiple IPDL specs in one invocation