trim leading and trailing whitespace from signature input

RESOLVED FIXED in 1.3

Status

RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: wsmwk, Assigned: ryansnyder)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
trim leading and trailing whitespace from signature input to avoid search failures

NOTE: additionally, once the form has whitespace at end of the signature it's hard to get rid of (at least on windows). for example
1. do http://crash-stats.mozilla.com/query/query?do_query=1&product=Thunderbird&date=12%2F01%2F2008&range_value=21&range_unit=days&query_search=signature&query_type=exact&query=VirtualFolderChangeListener%3A%3AOnHdrDeleted%28nsIMsgDBHdr*%2C+unsigned+int%2C+int%2C+nsIDBChangeListener*%29+
2. on results page thunderbird 3.0a1 is selected, click 3.0a1
to unselect it
3. click advanced filters
4. click end of signature and backspace over the trailing space
5. run filter

results: it filters with the same trailing space, and you get the same failed results
Assignee: nobody → ryan
Target Milestone: --- → 1.3
Created attachment 416672 [details] [diff] [review]
Patch 1 for #502699

Changed rawurldecode() to urldecode(), which converts spaces in the url from "+" to " ".  Also added trim() where appropriate.
Attachment #416672 - Flags: review?(ozten.bugs)
Comment on attachment 416672 [details] [diff] [review]
Patch 1 for #502699

Looking good!
Attachment #416672 - Flags: review?(ozten.bugs) → review+
Fixed and committed.

==

Sending        application/libraries/MY_Controller.php
Sending        application/views/common/query_form.php
Transmitting file data ..
Committed revision r1598.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.