502699 - trim leading and trailing whitespace from signature input

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Wayne Mery (:wsmwk)]

trim leading and trailing whitespace from signature input to avoid search failures

NOTE: additionally, once the form has whitespace at end of the signature it's hard to get rid of (at least on windows). for example
1. do http://crash-stats.mozilla.com/query/query?do_query=1&product=Thunderbird&date=12%2F01%2F2008&range_value=21&range_unit=days&query_search=signature&query_type=exact&query=VirtualFolderChangeListener%3A%3AOnHdrDeleted%28nsIMsgDBHdr*%2C+unsigned+int%2C+int%2C+nsIDBChangeListener*%29+
2. on results page thunderbird 3.0a1 is selected, click 3.0a1
to unselect it
3. click advanced filters
4. click end of signature and backspace over the trailing space
5. run filter

results: it filters with the same trailing space, and you get the same failed results

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 1 for #502699

Changed rawurldecode() to urldecode(), which converts spaces in the url from "+" to " ".  Also added trim() where appropriate.

Comment 2

[Austin King [:ozten]]

Comment on attachment 416672 [details] [diff] [review]
Patch 1 for #502699

Looking good!

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Fixed and committed.

==

Sending        application/libraries/MY_Controller.php
Sending        application/views/common/query_form.php
Transmitting file data ..
Committed revision r1598.