Closed
Bug 502711
Opened 16 years ago
Closed 16 years ago
imgITools cannot decode images stored in JARs
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: robarnold, Assigned: robarnold)
References
Details
Attachments
(1 file)
|
1.68 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
This is because JARStreams are not buffered. imgITools should make a buffered stream if one is required rather than rewriting each decoder to handle non-buffered streams.
Attachment #387060 -
Flags: review?(joe)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 387060 [details] [diff] [review]
v1.0
Nothing catastrophic happens if NS_NewBufferedInputStream fails and inStream isn't set to a buffered stream, right? The images just fail to decode?
Attachment #387060 -
Flags: review?(joe) → review+
|
Assignee | |
Comment 2•16 years ago
|
||
Right. We'll just fall back to the old code which will fail in the same place and way it already does.
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•16 years ago
|
||
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/913714436524
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Assignee: nobody → tellrob
You need to log in
before you can comment on or make changes to this bug.
Description
•