502904 - Compiler warnings in jemalloc.c

Status: RESOLVED DUPLICATE of bug 1226907

(Core :: Memory Allocator, defect)

Description

[Sune Mølgaard]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; rv:1.9.1.1pre) Gecko/20090707 SeaMonkey/2.0b1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux x86_64; rv:1.9.1.1pre) Gecko/20090707 SeaMonkey/2.0b1pre

Compiling produces the following warnings:

jemalloc.c: In function ‘wrtmessage’:
jemalloc.c:1395: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
jemalloc.c:1396: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
jemalloc.c:1397: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
jemalloc.c:1398: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result

Reproducible: Always

Steps to Reproduce:
1. Compile
2. Watch output

Actual Results:  
Warnings

Expected Results:  
No warnings

Adding a patch, when I see how to diff correctly

Comment 1

[Sune Mølgaard]

Attachment: Patch to use write() as it should be

Comment 2

[Matthias Versen [:Matti]]

Comment on attachment 387258 [details] [diff] [review]
Patch to use write() as it should be

You have to request review from someone

Comment 3

[Jason Evans]

Comment on attachment 387258 [details] [diff] [review]
Patch to use write() as it should be

If the write(STDERR_FILENO, ...) call fails, fprintf(stderr, ...) is very likely to fail too.  See http://canonware.com/cgi-bin/hg_jemalloc/file/938eab26a83a/jemalloc/src/jemalloc.c (lines 1205-1209) for how I recently worked around this compiler warning in a different source repo.

Comment 4

[Sune Mølgaard]

Attachment: New patch cf. jasone's comment

Comment 5

[Matthias Versen [:Matti]]

Jason: can you help with bringing this patch into the tree ?
Do you know an sr for this patch ?

Comment 6

[Chris Peterson [:cpeterson]]

I fixed this mozjemalloc warnings in bug 1226907.