503047 - element.select() does not trigger select event anymore.

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[arno renevier]

Hi,
when selecting a text input with javascript (input.select()), it's select handler is not executed.
It works fine with firefox 3.0 and 3.5 but is broken in latest nightly.

Comment 1

[arno renevier]

Attachment: testcase

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Regression range would be very useful.

Comment 3

[arno renevier]

I don't known how to get a regression range. 
I'm trying to get builds on ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/
but it's a pain to find things: I'm trying to look in *-mozilla-central directories, but in most of them, there is no linux build.  Is there an easy way to get old xulrunner/firefox builds ?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

nightly builds are usually used to find regression range.
Linux builds are typically in the same -XX-mozilla-central, but from time to time
the -XX- changes.

It is usually best to use binary search (or similar) to find regression range.
We know that 1.9.1 doesn't have the bug and 1.9.1 branched late November 08. 
So I'd start from a build around mid March 09.

Comment 5

[arno renevier]

This one does not have the bug:
ftp://ftp.mozilla.org/pub/firefox/nightly/2009/06/2009-06-10-03-mozilla-central/

This one does:
ftp://ftp.mozilla.org/pub/firefox/nightly/2009/06/2009-06-11-03-mozilla-central/

Comment 6

[Boris Zbarsky [:bzbarsky]]

Sounds like a regression from the focus landing.

Comment 7

[Neil Deakin]

Attachment: windows don't GetInterface to nsIDocShellTreeItem, so use GetPrivateRoot instead

Comment 8

[Neil Deakin]

The code here is checking if the window is active and doesn't fire a select event if it is not. This was added by bug 92879 to avoid a focus stealing issue. I have a feeling that check may not be even needed anymore though. Perhaps we could simplify the code entirely.

Comment 9

[Neil Deakin]

Attachment: with working test

Comment 10

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/57b1b4511f46