Closed
Bug 503183
Opened 15 years ago
Closed 15 years ago
Use Overflow Containers for float continuations beyond end of containing block
Categories
(Core :: Layout: Floats, defect)
Core
Layout: Floats
Tracking
()
RESOLVED
FIXED
People
(Reporter: fantasai.bugs, Assigned: fantasai.bugs)
References
Details
Attachments
(3 files)
|
11.78 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
1001 bytes,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
12.22 KB,
patch
|
Details | Diff | Splinter Review |
We currently shift float continuation placeholders up and down the ancestor chain during reflow when the float continues past the end of a block. We should instead be using overflow containers to continue the block so that the float continuation placeholders don't need to do these weird things and can have a consistent parent element.
This patch is also needed in order to avoid regressing clear behavior.
Attachment #387731 -
Flags: review?(roc)
Attachment #387730 -
Flags: review?(roc) → review+
Attachment #387731 -
Flags: review?(roc) → review+
Very nice. I don't know if we have any tests with floats that require this special handling. Maybe you could set a breakpoint and run reftests and see if it gets hit. If it doesn't, we need some tests...
Fix checked in: http://hg.mozilla.org/mozilla-central/rev/0149bbd87df5 Testcase in bug 499377.
Flags: in-testsuite?
OS: Linux → All
Hardware: x86 → All
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•