503498 - Mozmill test to verify default bookmarks

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug will track the work for the Litmus test: https://litmus.mozilla.org/show_test.cgi?id=6717

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marco, I hope you can help me with my little problem I have for this test. The last item we check in this test is the Live Bookmark on the toolbar. When I query the historyService and check the uri property of the result node I only get "place:folder=69". But how can I get the feed url?

Comment 2

[Marco Bonardo [:mak]]

livemarkservice should be able to convert your item id (69) to a feed or site uri (see livemarkService.getFeedURI(folderId))

btw once you have the result node there's no need to get the uri, you can use node.itemId

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

It will check all three bookmark toolbar entries for en-US. For localized builds we have a problem with the default profile after startup. It has mixed content from en-US and e.g. German. It still works but we have to fix this part in Mozmill. I will file a bug on that.

Otherwise I'm not really sure how we should handle failures inside the modal dialog handlers. Because we don't stop the test and even don't report this failure shall we enclose it into a try/catch block to give it at least the change to close the dialog?

Comment 4

[Aakash Desai [:aakashd]]

Comment on attachment 391747 [details] [diff] [review]
Patch v1

Looks good, ran fine via IDE and commandline on OSX. Also, the comments are clear and the code fits within code conventions defined earlier.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Aakash. It has been checked in as:
http://hg.mozilla.org/qa/mozmill-tests/rev/1261d6a1a660

(In reply to comment #3)
> It will check all three bookmark toolbar entries for en-US. For localized
> builds we have a problem with the default profile after startup. It has mixed
> content from en-US and e.g. German. It still works but we have to fix this part
> in Mozmill. I will file a bug on that.

Filed as bug 508643.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Needed a fix for localized builds due to the redirection of the getting started page:

http://hg.mozilla.org/qa/mozmill-tests/rev/9a088b8e8aad
http://hg.mozilla.org/qa/mozmill-tests/rev/69065071444a

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Follow-up for trunk:
http://hg.mozilla.org/qa/mozmill-tests/rev/448d713db76c

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 9

[u279076]

This should have been marked verified long ago.