Closed
Bug 503524
Opened 16 years ago
Closed 16 years ago
JSON.stringify does not condition number-typed space parameter per spec
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: brendan, Assigned: brendan)
Details
(Whiteboard: fixed-in-tracemonkey, bake-time-5days:7/18)
Attachments
(1 file)
|
723 bytes,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
ES5 draft in 15.12.3 stringify ( value [ , replacer [ , space ] ] ) says
4.6. If Type(space) is number
a. Let space be min(10, ToInteger(space))the lesser of space and 100.
b. Set gap to a string containing space space characters. This will be the
empty string if space is less than 1.
/be
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Updated•16 years ago
|
Flags: wanted1.9.1.x?
|
||
Updated•16 years ago
|
Attachment #387888 -
Flags: review?(sayrer) → review+
|
|
||
Comment 2•16 years ago
|
||
there are a bunch of little issues like this, since the spec changed pretty late (IE8 has issues too). Should we try to get them on 1.9.1.1 ?
|
|
Assignee | |
Comment 3•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/216de166d504
I'm in favor of fixing this ASAP. It's a safe fix. ES5 benefits from being tested as currently drafted, and we don't expect changes here.
/be
Whiteboard: fixed-in-tracemonkey
|
|
||
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Whiteboard: fixed-in-tracemonkey → fixed-in-tracemonkey, bake-time-5days
|
|
||
Updated•16 years ago
|
Whiteboard: fixed-in-tracemonkey, bake-time-5days → fixed-in-tracemonkey, bake-time-5days:7/18
You need to log in
before you can comment on or make changes to this bug.
Description
•