503627 - Exiting Page Setup causes broken Print Preview

Status: RESOLVED FIXED

(Core :: Print Preview, defect, P2)

Description

[Hideo Oshima]

Attachment: Broken Print Preview

Steps to reproduce:
1. Open any web page
2. Open print preview by File -> Print Preview
3. Click "Page Setup" button
4. Click "Cancel" or "Apply" button to exit Page Setup

Actual Result:
See screenshot.

My environment:
Distro: Debian GNU/Linux sid
GTK+: 2.16.4-1
GNOME: 2.26

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090711 Minefield/3.6a1pre

Comment 1

[Masahiro YAMADA]

再現しません。OSもしくはテーマ依存でしょうか？
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090714 Minefield/3.6a1pre

Comment 2

[Masahiro YAMADA]

(In reply to comment #1)
> 再現しません。OSもしくはテーマ依存でしょうか？
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090714
> Minefield/3.6a1pre

Oops
What I want to say is:
Not reproduced at Windows XP.
It seems to depends on OS or theme.

Comment 3

[Daniel Holbert [:dholbert]]

I can confirm that this is broken on Ubuntu 9.04, with a fresh Firefox profile, loading about:blank as the only tab, and following steps in comment 0.

It's WFM in Firefox 3.5, though --> regression, regressionwindow-wanted

BROKEN:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090712 Minefield/3.6a1pre

WORKING:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5

Comment 4

[Daniel Holbert [:dholbert]]

Regression range:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090610 Minefield/3.6a1pre
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090611 Minefield/3.6a1pre
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=90d3e6d2cbb9&tochange=4430cae50dad

Possibly a regression from Bug 178324?

Comment 5

[Daniel Holbert [:dholbert]]

Confirmed regression from bug 178324, using targeted builds.  (changeset 771509552a2e is WFM, changeset cabb8925dcd3 is broken.)

Comment 6

[Neil Deakin]

Unlikely to be caused by 178324, but a bug that was there already.

In fact, this bug is similar to bug 267422 where various workarounds/hackery were added to get this to work. I suspect that the problem is that different workarounds/hackery are needed, as reflows occur at a different point. (For example, checking if something is focusable now always reflows, whereas before it sometimes did and sometimes did not).

Comment 7

[Daniel Holbert [:dholbert]]

Requesting blocking1.9.2 -- this bug severely breaks the print-preview UI. (see attached screenshot)

Comment 8

[Neil Deakin]

Attachment: well that was a fun 2 days, fix this bug

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 399560 [details] [diff] [review]
well that was a fun 2 days, fix this bug

eek.

Comment 10

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/acd4bfec5813