503639 - [Mac OS X] Right-click on menu from folder from bookmark bar triggers context menu

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[philippe (part-time)]

Attachment: screenshot of offending context menu

STR
1. put a folder containing bookmarks on the bookmark bar
2. click on that folder --> menu with list of bookmarks appears
3. (accidentally) right-click on that menu

Actual results: a context menu is triggered
Expected results: right click is disabled, registered as normal click

This is the normal Mac OS X UI behaviour.

regression between 20090622 and 20090623
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7c96ea5e9df1&tochange=28aa23105a9e

--> bug 486990 probably

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: a patch

Neil, what do you think about this approach.
Mouse generated context menu and key generated context menu should be handled in the same way.

This clearly requires a mochitest.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 388509 [details] [diff] [review]
a patch

Apparently this is wrong. Though, I'm not quite sure what is the right thing to do.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

...because I'm not sure what is the normal behavior on OSX.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This way then. Keyboard-contextmenu event is prevented like before, but
normal contextmenu only if the event is targeted somewhere in a menu popup.

Comment 5

[Neil Deakin]

Comment on attachment 394010 [details] [diff] [review]
patch

Looks ok. It would be nice to combine the code so as not to call GetTopPopup twice.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Yeah, perhaps. Though having two different methods keeps them reasonable
small and well defined. And GetTopPopup shouldn't be too slow to call.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/b50beb2bef47

Comment 8

[philippe (part-time)]

Thanks !

Verified with 
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a2pre) Gecko/20090813 Minefield/3.6a2pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090814 Minefield/3.7a1pre

(and removing the blocking request)