503677 - JIT implementation of Tamarin Central does not work on ARMV7.

Status: VERIFIED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P2)

Description

[sea]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.19) Gecko/20081202 Iceweasel/2.0.0.19 (Debian-2.0.0.19-0etch1)
Build Identifier: 

JIT implementation of Tamarin Central is not working on ARMV7.

Reproducible: Always

Comment 1

[sea]

JIT implementation of Tamarin Central is not working on ARMV7. Here are some findings:

avmplus::MethodInfo::pool (this=0x1) at /home/user/tamarin-central-arm/core/MethodInfo.h:323
1: $pc = (void (*)(void)) 0x85808 <avmplus::MethodInfo::pool() const>
(gdb) p _pool
Cannot access memory at address 0x11

Then before modifying env->_implGPR, it contains:

(gdb) p env->_implGPR
$28 = (
    avmplus::MethodInfo::._75::GprMethodProc) 0xa7294 <avmplus::MethodEnv::delegateInvoke(avmplus::MethodEnv*, int, unsigned int*)>
(gdb) si
168     in /home/user/tamarin-central-arm/core/MethodInfo.cpp
1: $pc = (void (*)(void)) 0xb1628 <avmplus::MethodInfo::verifyEnter(avmplus::MethodEnv*, int, unsigned int*)+120>
(gdb) p env->_implGPR
$29 = (avmplus::MethodInfo::._75::GprMethodProc) 0x40389f9c
(gdb) x 0x40389f9c
0x40389f9c:     0xe92d4ff0 ( Unmapped memory )

avmplus::_AvmAssertMsg (assertion=1077118008,
    message=0x1d8018 "Assertion failed: \"((!f->pool()->core->config.verifyall))\" (\"/home/user/tamarin-central-arm/core/MethodInfo.cpp\":155)")

0x000b1668 <_ZN7avmplus10MethodInfo11verifyEnterEPNS_9MethodEnvEiPj+184>:       blx     r3  ( This is the place where VM hangs )

Here is the [prolog]:

0x4038bfec  [npe]                           r0(env)
  0x4038bfec  ldr lr, [pc, #-0xFEC]           r0(env)
  0x4038bff0    (-4076(PC) = 0xa7d10)         r0(env)
  0x4038bff0  blx lr
        0x4038bff4:
  0x4038bff4  [epilogue]
  0x4038bff4  mov sp, fp
              pop 8ff0

Comment 2

[sea]

JIT implementation of Tamarin Redux works on ARMV7 after bug 497596 is fixed. It's quite important to merge TR JIT to TC. There are many changes regarding nanojit on Tamarin Redux. It would be really useful to merge them to TC soon.

Comment 3

[Steven Johnson]

(In reply to comment #2)
> JIT implementation of Tamarin Redux works on ARMV7 after bug 497596 is fixed.
> It's quite important to merge TR JIT to TC. There are many changes regarding
> nanojit on Tamarin Redux. It would be really useful to merge them to TC soon.

Agreed, it's long overdue. We're hoping to get a TR->TC merge done sometime this week. Stay tuned :-)

Comment 4

[sea]

Can anybody confirm the status of this bug. Is TC working on ARMV7?

Comment 5

[sea]

(In reply to comment #3)
> (In reply to comment #2)
> > JIT implementation of Tamarin Redux works on ARMV7 after bug 497596 is fixed.
> > It's quite important to merge TR JIT to TC. There are many changes regarding
> > nanojit on Tamarin Redux. It would be really useful to merge them to TC soon.
> 
> Agreed, it's long overdue. We're hoping to get a TR->TC merge done sometime
> this week. Stay tuned :-)

TR->TC is not merged yet. Steven, could you please confirm when it will be done. As you know, it's really quite important. 

Importance to Critical!

Comment 6

[Steven Johnson]

(In reply to comment #5)

> TR->TC is not merged yet. Steven, could you please confirm when it will be
> done. As you know, it's really quite important. 
> 
> Importance to Critical!

Comment 7

[Steven Johnson]

(In reply to comment #6)
> > TR->TC is not merged yet. Steven, could you please confirm when it will be
> > done. As you know, it's really quite important. 
> > 
> > Importance to Critical!

Wish I could give you a specific date, but I can't. At this point the best I can say is: sometime in September.

Comment 8

[Edwin Smith]

closing this out as fixed since it is fixed in tamarin-redux; bug 486742 tracks the tamarin-redux to tamarin-central work.