503813 - changing generated content on :hover does not work when the hovering is over the generated content

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Atsushi Sakai]

Attachment: testcase

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090712 Minefield/3.6a1pre

Steps to reproduce:
1. Open the testcase.
2. Mouse over "generated content" at the right of "testA".

Actual result:
Does nothing.

Expected result:
:hover should work like testB, i.e. "generated content" in testA should change to red "content is used with hover".

20080817033619 works fine.
20080818033342 fails.

Likely from bug 238072.

Comment 1

[Atsushi Sakai]

Attachment: testcase with <a>

When this bug occurs with <a>, click on the generated content does not work first time.

In this testcase, clicking on "generated content" at the right of "testA" once does nothing.
When click again, it follows the link.
Is this the same bug? Or another separate bug is needed?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

GetContentForEvent should return the nearest enclosing non-generated content.

This function is used in quite a few places but I'm pretty sure this is the right thing to do in all those cases. We simply shouldn't be targeting DOM events at  generated content.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This patch fixes both testcases in this bug.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 397605 [details] [diff] [review]
fix

r=dbaron

But I think you should also remove nsHTMLCanvasFrame::GetContentForEvent; it's now the only GetContentForEvent implementation that doesn't do this fixup, and as far as I can tell it's entirely unneeded.  (I can't see how it can occur in generated content now, but we may as well avoid problems if it ever can.)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/9ada244c11b3

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Wed Sep 02 14:46:33 2009 +1200 (at Wed Sep 02 14:46:33 2009 +1200):
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/41c751e0aab1

Comment 8

[Michael Ryan]

Confirmed fixed in 1.9.2.