503886 - Allow non-mozilla central applications to use automation-build.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mark Banner (:standard8)]

Attachment: [checked in] Trunk patch

I am trying to hook up a new makefile driver test harness (at least initially) for Thunderbird. As part of that I want to use automation.py - which means the best way is for me to include automation-build.mk.

Unfortunately automation-build.mk is using $(topsrcdir) which means I can't include it. As it is always used after rules.mk, we can swap it to use $(MOZILLA_DIR) which will point to the mozilla source directory whether in the mozilla-central or comm-central build systems.

Trunk and branch are a bit different so I'll attach a patch for branch in a bit.

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> Created an attachment (id=388235) [details]
> Trunk patch

Forgot to say, I ran this patch through try server with no problems.

Comment 2

[Mark Banner (:standard8)]

Attachment: 1.9.1 branch patch

Branch version of the patch.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 388235 [details] [diff] [review]
[checked in] Trunk patch

Checked into trunk:

http://hg.mozilla.org/mozilla-central/rev/465f87d82960

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 388244 [details] [diff] [review]
1.9.1 branch patch

Not 100% sure if I need approval of this or not, so requesting just in case.

This patch changes the file that generates automation.py so that it can be generated and used non-mozilla-central specific testing code.

Thunderbird wants this for some of its testing code.

AFAIK this code is only used in testing the trunk builders have been unaffected by the trunk version of the patch.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 388244 [details] [diff] [review]
1.9.1 branch patch

This is NPOTB, doesn't need approval from drivers.

Comment 6

[Mark Banner (:standard8)]

Checked in to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/029098856189

Comment 7

[u279076]

What is the best/simplest way for QA to verify this for Firefox 3.5.2?

Comment 8

[Mark Banner (:standard8)]

I guess all the test suites that use it are still running e.g. mochitest xpcshell etc etc (oh and that Thunderbird is able to run MozMill which uses it, which can be found here: http://tinderbox.mozilla.org/showbuilds.cgi?tree=ThunderbirdTest, ignore the red/orange, there's some passed tests on there somewhere!).