503936 - "ASSERTION: frame must have content (unless at the top of the tree)" with floating first-letter, range operations

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: SetMayHaveFrame failed?: 'mContent->MayHaveFrame()', file /Users/jruderman/central/layout/generic/nsFrame.cpp, line 369

###!!! ASSERTION: frame must have content (unless at the top of the tree): 'aFrame->GetContent() || !aParentContent || !aParentContent->GetParent()', file /Users/jruderman/central/layout/base/nsFrameManager.cpp, line 1096

Also, the 'F' remains on the screen, and I think it shouldn't.

Related to bug 483346?  (See bug 483346 comment 2.)

Comment 1

[Boris Zbarsky [:bzbarsky]]

> ###!!! ASSERTION: SetMayHaveFrame failed?: 'mContent->MayHaveFrame()', file
> /Users/jruderman/central/layout/generic/nsFrame.cpp, line 369

This means mContent is a text node with a null parent.

> ###!!! ASSERTION: frame must have content (unless at the top of the tree):

This would be a first-letter frame with a null mContent.  Not sure how it got there.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Ah, it happens because we init the first-letter frame with letterContent, which is gotten like so:

  nsIContent* letterContent = aTextContent->GetParent();

So the real issue is that aTextContent isn't actually in the tree anymore...

Comment 3

[Timothy Nikkel (:tnikkel)]

The patch in bug 457514 fixes this.

Comment 4

[Jesse Ruderman]

Yep, seems fixed.

Comment 5

[Jesse Ruderman]

tn added this as a crashtest:
http://hg.mozilla.org/mozilla-central/rev/790386742994

Comment 6

[Timothy Nikkel (:tnikkel)]

And also on 1.9.2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e64520854382