504167 - Create simple LDAP-driven PTO app

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Webdev, task)

Description

[Michael Morgan [:morgamic]]

Need:
- 1 database table
- LDAP auth
- email notification -- needs to email:
-- karen@m.c, erica@m.c, person's manager (as pulled from LDAP)
- a simple form that looks like:

PTO Notification
Reason: [    ]
Start: [  ] (w/ datepicker)
End: [  ] (w/ datepicker)
Submit

Comment 1

[Michael Morgan [:morgamic]]

Additionally, a JSON feed so this can be used internally in a dashboard will be needed eventually.

Comment 2

[Michael Morgan [:morgamic]]

Attachment: mock showing the form we want

Comment 3

[Wil Clouser [:clouserw]]

What do you think of an additional field to email other people/groups?  Most of the time when I want PTO I also want to let [e-mail] know.

Comment 4

[Wilson Lee [:kourge]]

http://kourge.khan.mozilla.org/pto/

(Accessible through Mozilla-MPT on VPN.)

It currently does not actually email your manager (even though he/she will show up), nor does it email Karen or Erica. It will, however, CC you (if you check the box) and mail to any address you manually enter in the box.

A JSON feed is available at http://kourge.khan.mozilla.org/pto/json.php and there are currently four parameters accepted:
- "valid_mime=1" will change the response Content-Type from "application/javascript" to "application/json".
- "start" accepts a Unix timestamp and will filter out any submitted PTOs that start before such timestamp.
- "end" accepts a Unix timestamp and will filter out any submitted PTOs that end after such timestamp.
- "person" accepts a string, which will be used to narrow down to PTOs submitted by those whose alias contains such string. An alias is defined as the username of your formal @mozilla.com address, not your aliased one.

Comment 5

[Dan Portillo]

ideally it should email Karen, the person's manager and have an option field for additional emails. Hopefully a note that says "all" is not acceptable. Great work on this!

Comment 6

[Wilson Lee [:kourge]]

It *is* able to do that right now; the code that does that is currently commented out to avoid spamming Karen and the person's manager as this tool is currently in testing.

Comment 7

[Dan Portillo]

thanks for clarifying

Comment 8

[Michael Morgan [:morgamic]]

I chatted with Wilson - we have a few things left to do including a simple report tool for Karen and HR so they can get an instant report on who is on PTO every week.  Once that's done we can wrap this up -- hopefully tomorrow.

Thanks for the hard work, Wilson!

Comment 9

[Wilson Lee [:kourge]]

json.php is now renamed export.php since multiple exporting formats are now supported.

The old parameters are still valid, a new parameter is added, called "format". Therefore, what used to be http://kourge.khan.mozilla.org/pto/json.php is now effectively http://kourge.khan.mozilla.org/pto/export.php?format=json since new formats are added. CSV is currently supported, with a pretty HTML interface on the way, which would show up when export.php is requested without a format.

Comment 10

[Justin Fitzhugh]

report access should probably be limited to hr...

Comment 11

[Michael Morgan [:morgamic]]

Why?  It just reports who is out when.  People with LDAP should be able to see it, no?

Comment 12

[Michael Morgan [:morgamic]]

HR should be the only people able to see the reason, I think... the status isn't protected, is it?

Comment 13

[Justin Fitzhugh]

agreed - reason should be internal.

Comment 14

[Dan Portillo]

it should be internal and optional.

Comment 15

[Wilson Lee [:kourge]]

The reason is now labeled as optional and is not shown to those outside of the HR department.

Comment 16

[David Ascher (:davida)]

We'd like to be able to use this code for MoMo folks as well.  Gozer will propose a patch that should work, but we're ok w/ running our own instance as well if that works better for folks.

Comment 17

[Philippe M. Chiasson (:gozer)]

Attachment: Small change to allow mozillamessaging folks as well.

I am not certain what the LDAP schema, however, so I am assuming here that o=com,dc=mozillamessaging is where we are stashed at, but that might be incorrect.

Comment 18

[Reed Loden [:reed]]

Comment on attachment 392549 [details] [diff] [review]
Small change to allow mozillamessaging folks as well.

MoMo people are just under o=net with mail addresses containing @mozillamessaging.com. Might be time to move MoMo people to their own branch, though.

Comment 19

[Wilson Lee [:kourge]]

Patch committed at r48570.

Comment 20

[Reed Loden [:reed]]

(In reply to comment #19)
> Patch committed at r48570.

???? I gave the patch r-, meaning it's not acceptable at all. Please back out your commit.

Comment 21

[Wilson Lee [:kourge]]

Sorry, I didn't pay attention. Backed out at r48575.

Comment 22

[Michael Morgan [:morgamic]]

So this is what I'm seeing:
- back out something that works right now
- wait indefinitely for some change that may take weeks

That's not the answer.  If what Wilson has works now, push it now then update it when we change LDAP around.  If we do it the other way, we block progress for Wilson and I'm not interested in doing that.

Comment 23

[Michael Morgan [:morgamic]]

Is there a compromise?  What can we check in to get it working right now?

Comment 24

[:Gavin Sharp [email: [e-mail]]]

Does it actually work? Reed's comment implies to me that it wouldn't, and I imagine that's why he gave it r-.

Comment 25

[Philippe M. Chiasson (:gozer)]

Attachment: Allow mozillamessaging folks as well v2

From a small irc chat with reed, I've been told momo folks live under:
o=net,dc=mozilla, so here comes an adjusted patch to account for this properly.

Comment 26

[Wilson Lee [:kourge]]

There's more to the app than just fixing auth.php. I am currently refactoring all of the files seen below, revealed by simple grepping:
http://pastebin.mozilla.org/665914

I've currently patched all of the files. ldap_find() in pto.inc is a difficult one to patch, since ldap_find() always searches with a base DN of "o=com,dc=mozilla". I'm resorting to performing two searches (one with o=com, one with o=net) and then returning the non-zero result.

Comment 27

[Wilson Lee [:kourge]]

Attachment: Remove o=com dependency

Comment 28

[Reed Loden [:reed]]

You need to support o=org for MoFo folks, so just search based on dc=mozilla. You won't ever have two people with the same mail, even if they are in different orgs.

Comment 29

[Wilson Lee [:kourge]]

Attachment: Remove o=com dependency, v2

Comment 30

[Wilson Lee [:kourge]]

Okay, the base DN for searches is now dc=mozilla.

Comment 31

[Dan Portillo]

would it be possible to add a field for which organization they belong to?

US
CAD
MZ Denmark
New Zealand