Closed Bug 504367 Opened 16 years ago Closed 16 years ago

Remove unneeded focus caching on back/forward

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: enndeakin, Unassigned)

Details

Attachments

(1 file)

The code in nsGlobalWindow::WindowStateHolder isn't needed. The focus will be restored properly on back/forward during the pageshow event already (in nsFocusManager::WindowShown) and the focus handling in WindowStateHolder is redundant and not quite correct in some cases. This causes bugs like the following: 1. Open any page. 2. Click a link on that page. 3. Focus the urlbar. 4. Go back. Actual: The link that was clicked is now focused Expected: The urlbar should still be focused
Attachment #388741 - Flags: review?(bzbarsky)
Attachment #388741 - Flags: review?(bzbarsky) → review+
Comment on attachment 388741 [details] [diff] [review] remove unneeded code Makes sense.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: