Closed
Bug 504367
Opened 15 years ago
Closed 15 years ago
Remove unneeded focus caching on back/forward
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: enndeakin, Unassigned)
Details
Attachments
(1 file)
|
7.36 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The code in nsGlobalWindow::WindowStateHolder isn't needed. The focus will be restored properly on back/forward during the pageshow event already (in nsFocusManager::WindowShown) and the focus handling in WindowStateHolder is redundant and not quite correct in some cases. This causes bugs like the following: 1. Open any page. 2. Click a link on that page. 3. Focus the urlbar. 4. Go back. Actual: The link that was clicked is now focused Expected: The urlbar should still be focused
Attachment #388741 -
Flags: review?(bzbarsky)
|
||
Updated•15 years ago
|
Attachment #388741 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 388741 [details] [diff] [review] remove unneeded code Makes sense.
|
Reporter | |
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c8a66d96c1a1
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•15 years ago
|
Flags: in-testsuite+
|
Assignee | |
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•