Closed
Bug 504405
Opened 16 years ago
Closed 16 years ago
pkix_pl_CrlDp_Create will fail on alloc success because of a missing !
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.4
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
(Keywords: coverity)
Attachments
(1 file)
|
1.04 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
154 rdnArena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE);
155 if (rdnArena) {
156 PKIX_ERROR(PKIX_PORTARENAALLOCFAILED);
157 }
158 issuerNameCopy = (CERTName *)PORT_ArenaZNew(rdnArena, CERTName*);
you wanted it the other way.
|
||
Updated•16 years ago
|
Group: core-security
|
|
||
Updated•16 years ago
|
Group: core-security
Attachment #388777 -
Flags: review?(nelson)
|
||
Comment 2•16 years ago
|
||
timeless, I agree that the code is wrong, and your patch fixes it.
But I see no crash here, not even a leak. Where do you see it?
Is it a crash in the caller of this function?
If so, this patch doesn't correct the actual cause of the crash.
sorry. i didn't mean crash...
it will crash on alloc failure :)
Summary: pkix_pl_CrlDp_Create will crash on alloc success because of a missing ! → pkix_pl_CrlDp_Create will fail on alloc success because of a missing !
|
|
||
Updated•16 years ago
|
Severity: critical → major
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 388777 [details] [diff] [review]
patch
r=nelson. I will commit.
Attachment #388777 -
Flags: review?(nelson) → review+
|
|
||
Updated•16 years ago
|
Priority: -- → P2
Target Milestone: --- → 3.12.4
Version: trunk → 3.12.3
|
|
||
Comment 5•16 years ago
|
||
module/pkix_pl_aiamgr.c; new revision: 1.12; previous revision: 1.11
pki/pkix_pl_crldp.c; new revision: 1.2; previous revision: 1.1
Assignee: alexei.volkov.bugs → timeless
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•