504474 - JS_ValueToBoolean is void

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[timeless]

according to brendan JS_ValueToBoolean will never return JS_FALSE, so we can stop pretending it will. This will make Coverity happy since we're slightly inconsistent at this point.

Comment 1

[timeless]

Attachment: stop checking the return value

Comment 2

[Brendan Eich [:brendan]]

The API could be changed too, but at some cost to embedders. Probably better to focus on new C++ API.

/be

Comment 3

[Brendan Eich [:brendan]]

In any new API that was infallible, the cx param would go, since its presence implies fallibility -- it is used only to CHECK_REQUEST(cx) in the current API wrapper impl.

Could have new API in jsapi.h, but opt-in by name or ifdef. Worth it? Comments welcome.

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 388844 [details] [diff] [review]
stop checking the return value

Just noticed the quickstub generation code uses PRBool to declare the out param, which works because JSBool is PRBool is int, but JSBool is better.

Looking mainly for jorendorff's blessing since I am weak reviewer for the quickstubs code, at best.

/be

Comment 5

[timeless]

http://hg.mozilla.org/mozilla-central/rev/2956e5255fc9