Closed
Bug 504475
Opened 15 years ago
Closed 14 years ago
closing last tab shows tab bar with "Always show the tab bar" off, and browser.tabs.closeWindowWithLastTab = false
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.7a1
People
(Reporter: ddan39, Assigned: dao)
References
Details
Attachments
(1 file)
1.23 KB,
patch
|
Gavin
:
review+
christian
:
approval1.9.2.7-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1) Gecko/20090715 Firefox/3.5 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1) Gecko/20090715 Firefox/3.5 Firefox 3.5 built on Linux When I turn off "Always show the tab bar" the tab bar should only show when there is more than 1 tab. If there is only 1 tab there should be no tab bar. With the preference "Always show the tab bar" OFF and about:config option browser.tabs.closeWindowWithLastTab = false, and there is only 1 tab(no tab bar showing) if you close the last tab it will bring up a blank page and show the tab bar with only 1 tab. The tab bar should not be showing. Reproducible: Always Steps to Reproduce: 1. Change about:config option browser.tabs.closeWindowWithLastTab = false 2. Uncheck "Always show the tab bar" in Preferences under Tabs 3. Close all tabs but the last one 4. Close the last tab with File>Close or CTRl+W Actual Results: The tab is closed, a blank page shows, and the tab bar appears with just 1 tab. Expected Results: The tab should close, show a blank page, and NO tab bar should be showing.
Summary: with "Always show the tab bar" off, and browser.tabs.closeWindowWithLastTab = false, closing last tab shows tab bar → closing last tab shows tab bar with "Always show the tab bar" off, and browser.tabs.closeWindowWithLastTab = false
Assignee | ||
Updated•15 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•15 years ago
|
OS: Linux → All
Hardware: x86 → All
The behavior previous to Ff 3.5 was correct, &, when attempting to close the last tab in the above circumstances, would flash creating a new tab followed by closing the current (previously last) tab. Since Ff 3.5 beta(s), this behavior is exhibited. Currently, I sidestep this by manually opening a new tab, & closing the previous one, which still works. Any coders interested?
Flags: wanted1.8.1.x?
Flags: in-testsuite?
Flags: in-litmus?
Flags: blocking1.9.1.1?
Flags: blocking1.9.0.13?
Flags: blocking1.9.0.12?
Flags: blocking1.8.1.next?
Flags: blocking-firefox3.6?
Comment 2•15 years ago
|
||
@TPSamuel: this is not this bug, rather see Bug 456405. And please do note abuse flag usage.
Flags: wanted1.8.1.x?
Flags: in-testsuite?
Flags: in-litmus?
Flags: blocking1.9.1.1?
Flags: blocking1.9.0.13?
Flags: blocking1.9.0.12?
Flags: blocking1.8.1.next?
Flags: blocking-firefox3.6?
I think this bug is valid, as I've read the mentioned bug's comments, & it doesn't precisely address *this* issue. As I understand it, *that* bug is regarding browser.tabs.closeWindowWithLastTab = false not being honored, which is *not* the problem I'm having. For me, the setting _is_ being honored, but the tab bar stays *stuck* visible with the last tab closed, although my config regarding "Always show tab bar" is false. & I apologize very much for the abusive flag spam.
This bug is not about the about:config option working or not. It DOES seem to work, since the last tab is "closed". The problem is that the tab bar is showing when it is not suppose to.
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → dao
Assignee | ||
Comment 6•15 years ago
|
||
Attachment #390646 -
Flags: review?(gavin.sharp)
Updated•14 years ago
|
Attachment #390646 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f077fca0d235
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Assignee | ||
Updated•14 years ago
|
Attachment #390646 -
Flags: approval1.9.2.1?
Comment 9•14 years ago
|
||
Comment on attachment 390646 [details] [diff] [review] patch We missed 1.9.2.2. Moving approval request forward.
Attachment #390646 -
Flags: approval1.9.2.2? → approval1.9.2.3?
Assignee | ||
Updated•14 years ago
|
Attachment #390646 -
Flags: approval1.9.2.5?
Attachment #390646 -
Flags: approval1.9.2.7?
Attachment #390646 -
Flags: approval1.9.2.6-
Attachment #390646 -
Flags: approval1.9.2.5?
Attachment #390646 -
Flags: approval1.9.2.4?
Comment 10•14 years ago
|
||
Comment on attachment 390646 [details] [diff] [review] patch We will not be taking this for 3.6.6. Moving approval request forward. If you disagree, send me an email.
Updated•13 years ago
|
Attachment #390646 -
Flags: approval1.9.2.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•