Closed Bug 504487 Opened 14 years ago Closed 14 years ago

nativeBindings is unused in nsXBLWindowKeyHandler::WalkHandlers

Categories

(Core :: XBL, defect)

Product:
Core
Component:
XBL
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: coverity)

Attachments

(1 file)

simplest patch
702 bytes, patch
neil
: review+
Details | Diff | Splinter Review 
GetEditorKeyBindings() sets sNativeEditorBindings and returns it, the nsXBLWindowKeyHandler::WalkHandlers stores the result in nativeBindings and then uses sNativeEditorBindings instead.
Attached patch simplest patch — — Splinter Review 

        Attachment #388856 -
        Flags: review?(neil)

    
    

    
  
Comment on attachment 388856 [details] [diff] [review]
simplest patch

Looks like bz overlooked this when he reviewed bryner's patch in attachment 158374 [details] [diff] [review] :-(

        Attachment #388856 -
        Flags: review?(neil) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/2aa2a2718383
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.