504498 - Add memmove to list of functions for which next frame should be included in signature

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Jesse Ruderman]

The topcrash list for Firefox 3.5 includes

memmove
memcpy | fillInCell

memmove is another one of those utility functions where crashes are always the fault of the caller, and I guess I neglected list it in bug 411349.  Can you add it now?

Comment 1

[Jesse Ruderman]

Also:

strlen
PL_strlen

Comment 2

[Jesse Ruderman]

Two more common ones from Firefox crash stats:

RaiseException
wcslen

Comment 3

[K Lars Lohn [:lars] [:klohn]]

I've made an IT request for this change

Comment 4

[Jesse Ruderman]

arena_dalloc is another one. (Do I need to file a new bug at this point?)

Comment 5

[K Lars Lohn [:lars] [:klohn]]

Jesse: no, you need not file another bug since I just have to file one for IT - no need to proliferate bugs.  

I've submitted IT bug 512309 to address this issue.

Comment 6

[K Lars Lohn [:lars] [:klohn]]

I believe these requests have all been addressed - correct me if I'm wrong.

Comment 7

[Zack Weinberg (:zwol)]

We found another group of these in bug 527567: all nsCOMPtr_base and nsCOMPtr<T> methods.  There's an unbounded set, because nsCOMPtr is a template - can the system handle that?  If regular expressions are used, you could just key off \<nsCOMPtr(_base\>|<)...

Comment 8

[Zack Weinberg (:zwol)]

It occurs to me that you might as well do \<nsRefPtr(_base\>|<) at the same time.

Comment 9

[chris hofmann]

there maybe firefox 3.6 blocker bugs hidding under Bug 527567 and others that depend on making these skip list changes.

we can't get at that analysis until these changes go in and the analysis continues on the other bugs..

Comment 10

[Zack Weinberg (:zwol)]

Closing again as this was dealt with in bug 530684.