Closed Bug 504513 Opened 10 years ago Closed 10 years ago

DownloadLastDir.jsm is imported during startup

Categories

(Firefox :: Private Browsing, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.6a1
Tracking Status
status1.9.1 --- wontfix

People

(Reporter: rflint, Assigned: ehsan)

References

Details

(Keywords: perf, Whiteboard: [ts])

Attachments

(1 file)

http://hg.mozilla.org/mozilla-central/annotate/547693481fd4/toolkit/content/contentAreaUtils.js#l526

There's no reason for this to be imported unconditionally into the global scope at startup with getTargetFile being the only consumer.
Whiteboard: [ts]
Attached patch Patch (v1)Splinter Review
Move away the loading of DownloadLastDir.jsm from the startup path.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #388893 - Flags: review?(gavin.sharp)
Attachment #388893 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/fa889d915991
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Comment on attachment 388893 [details] [diff] [review]
Patch (v1)

Zero-risk Ts win, nominating to land on 1.9.1.2.
Attachment #388893 - Flags: approval1.9.1.2?
Do you have numbers for the Ts win? I doubt it's significant, so I don't think we should bother trying to get this on the branch.
(In reply to comment #4)
> Do you have numbers for the Ts win? I doubt it's significant, so I don't think
> we should bother trying to get this on the branch.

No, it's not significant: <http://tinyurl.com/258pht> (sorry if the graph is not that useful; I didn't know how to generate a good graph link.)
Comment on attachment 388893 [details] [diff] [review]
Patch (v1)

not a significant enough win to take on the branch, I agree with gavin
Attachment #388893 - Flags: approval1.9.1.2? → approval1.9.1.2-
DownloadLastDir.jsm is still loaded at startup (through nsHelperAppDlg.js), but I've just nixed it in bug 536503 which should land soon.
You need to log in before you can comment on or make changes to this bug.