504513 - DownloadLastDir.jsm is imported during startup

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Ryan Flint [:rflint] (ping via IRC for reviews)]

http://hg.mozilla.org/mozilla-central/annotate/547693481fd4/toolkit/content/contentAreaUtils.js#l526

There's no reason for this to be imported unconditionally into the global scope at startup with getTargetFile being the only consumer.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Move away the loading of DownloadLastDir.jsm from the startup path.

Comment 2

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/fa889d915991

Comment 3

[(no longer active)]

Comment on attachment 388893 [details] [diff] [review]
Patch (v1)

Zero-risk Ts win, nominating to land on 1.9.1.2.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Do you have numbers for the Ts win? I doubt it's significant, so I don't think we should bother trying to get this on the branch.

Comment 5

[(no longer active)]

(In reply to comment #4)
> Do you have numbers for the Ts win? I doubt it's significant, so I don't think
> we should bother trying to get this on the branch.

No, it's not significant: <http://tinyurl.com/258pht> (sorry if the graph is not that useful; I didn't know how to generate a good graph link.)

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 388893 [details] [diff] [review]
Patch (v1)

not a significant enough win to take on the branch, I agree with gavin

Comment 7

[Geoff Lankow (:darktrojan)]

DownloadLastDir.jsm is still loaded at startup (through nsHelperAppDlg.js), but I've just nixed it in bug 536503 which should land soon.