504663 - tiki-rename_page.php times out for popular articles (optimise)

Status: RESOLVED INVALID

(support.mozilla.org :: General, defect)

Description

[Paul Craciunoiu [:paulc]]

Started from bug 444510, the code in wikilib->wiki_rename_page needs to be optimised. Renaming of popular articles times out and creates inconsistencies in the db.

Most of the work to rename is being done because tiki database tables do not use numeric id's to identify objects. For this specific situation, the page name is the primary key. Thus, changing the primary key causes huge overhead.

The long term solution is to redesign the tiki database to work with numeric id's rather than strings. Cheng mentioned a bug already filed about this latter aspect but I couldn't find it.

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This is at least better practice than the current code. Constructing a new object for every row in the result could be a significant slowdown. Hopefully it helps with bug 444510.

Comment 2

[Laura Thomson :laura]

Did you profile or benchmark this?  

All optimizations need to be done emprirically, otherwise it's just a waste of time.

Comment 3

[Laura Thomson :laura]

Comment on attachment 389000 [details] [diff] [review]
patch, v1

This doesn't look like an optiization.  Benchmark and resubmit when you have proof.

Comment 4

[Louis-Philippe Huberdeau]

It does not look like this was ever applied. I also agree with Laura's comment. Won't upstream this.

Comment 5

[James Socol [:jsocol, :james]]

Bugs in tikiwiki, going away.