504691 - Don't autocomplete search bookmarklets

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Stuart Morgan]

We shouldn't autocomplete search bookmarklets (bookmarks with %s in their URL). Many don't do anything useful if picked from the results list. There are probably examples where people could theoretically want them (e.g., a search engine where an empty search goes to the front page), but for that people can just add a second bookmark.

Example STR:
1) Have a search bookmarklet for https://bugzilla.mozilla.org/show_bug.cgi?id=%s
2) Type "bugzilla" in your location bar, wanting a history item
3) Be sad that the first item is a bookmark you can't do anything useful with

Comment 1

[Dan Weber]

Attachment: Patch 1

Comment 2

[Stuart Morgan]

Comment on attachment 389249 [details] [diff] [review]
Patch 1

This looks good, but thinking ahead to having more complexity in this method when title search is added, maybe it would be clearer as:

// Never autocomplete with search bookmarklets
if (<your test>)
  return NO;
<remainder of the logic>

Comment 3

[Stuart Morgan]

Can you post an updated patch here for superreview?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #3)
> Can you post an updated patch here for superreview?

Dan: ping ;)  Let's get this one in!

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Patch 1.1

This is the lost patches shepherd, helping patches find their way into the tree.

This is Dan's patch with smorgan's review comment addressed and also unbitrotted (title searches are a reality now).

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 439317 [details] [diff] [review]
Patch 1.1

sr=pink

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/843d069a19a3 (missed the bug number :( ) and cvs trunk.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

:sigh: and http://hg.mozilla.org/camino/rev/8b65e705feea where I backed out the part of hendy's patch that accidentally landed with it.  Not my day (but at least there's a sort-of reference to the bug number now :P ).