504716 - [ForumUX] Log in on the page when replying to threads instead of having to navigate away to a separate login page

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P4)

Description

[Paul Craciunoiu [:paulc]]

Currently the if you are logged out and you want to reply to a thread, you have to log in and get back to the thread,

Comment 1

[Paul Craciunoiu [:paulc]]

For security reasons, we cannot log in users through http://, thus, the proposed implementation is the following:
* if on http://, post the data to the https of the same page, fill in the reply with posted data, and show login form
* if on https://, include login form with the post and log in the user + create the reply

Objections? Look for a patch soon.

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: demo anonymous

Comment 3

[Paul Craciunoiu [:paulc]]

Attachment: demo contrib

Comment 4

[Paul Craciunoiu [:paulc]]

So I talked to Cheng and the UI for posting a reply could use some retouching. The above are proposed UI's for anonymous versus logged in users. Clicking on "Registered contributor?" in the first screenshot brings up the second, and vice versa for clicking on "Post without registering"

How's it look for you?

Comment 5

[[:Cww]]

Just a point, clicking on "registered contributor?" or "Post without registering" will NOT refresh the form data.

Comment 6

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This implements the behavior detailed in screenshots. Laura, have a good kick at it :)

Comment 7

[Majken Connor [:Kensie]]

"Post without registering" seems a bit misleading to me, unless users can register an account by filling in a username and password. For parity with "registered contributor?" I'd suggest "don't have an account?"

Normally this would be a problem because the answer to that is usually to point users to a registration form, however, we don't want to encourage users to sign up from threads where anonymous posting is allowed anyway.

Comment 8

[Laura Thomson :laura]

Not committed, load on QA means -> 1.4.1

Comment 9

[Paul Craciunoiu [:paulc]]

Attachment: patch, v2

Old patch failed to apply. I took the chance to update it with more friendly error messages (mistyping the antibot code doesn't take you to the error page), as well as make sure the comment is not posted (as anonymous) when login credentials are invalid.

The purpose of response seems to not be saved, but I could swear I saw a separate bug about that. Oh well, if there isn't, we'll file one.

Note: before reviewing this, I'd apply the patch from bug 518979 -- reverting to main index gets really annoying.

Hope I didn't miss anything!

Comment 10

[James Socol [:jsocol, :james]]

If I choose to log in while viewing the post from HTTP, I end up on HTTP again, shouldn't I be on HTTPS?

Comment 11

[Paul Craciunoiu [:paulc]]

Yes, I may have forgotten to post to https://

Comment 12

[James Socol [:jsocol, :james]]

Comment on attachment 403439 [details] [diff] [review]
patch, v2

Just need to make sure we're posting to HTTPS.

Comment 13

[Paul Craciunoiu [:paulc]]

Attachment: v3

There we go.

Comment 14

[James Socol [:jsocol, :james]]

Comment on attachment 403956 [details] [diff] [review]
v3

WFM, thanks!

Comment 15

[Paul Craciunoiu [:paulc]]

r52763 / r52764
Woot! I love usability improvements :)

Comment 16

[James Socol [:jsocol, :james]]

This landed a little earlier than expected ;)

Comment 17

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.

Comment 18

[David Tenser [:djst]]

Wow, really cool!