Closed Bug 504750 Opened 12 years ago Closed 12 years ago

Add splashscreen support to build system, Firefox part

Categories

(Firefox :: General, defect)

ARM
Windows CE
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.6a1

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

(Whiteboard: [nv])

Attachments

(1 file)

Bug 481494 added optional support for splash screens on slow devices, but didn't integrate with the build system for shipping the bitmap used.

This patch adds support for a splash.bmp in the build system that's used when a splashscreen is enabled. Bug 502526 will update the splash screens with polished artwork, this patch just includes the Firefox-branded splash vlad made (attached in 502526), and a couple placeholders for the unbranded and nightly branding.
Now with more splash.
Attachment #389087 - Flags: review?(benjamin)
Whiteboard: [nv]
Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]

We shouldn't ever be shipping Firefox with a splash screen, just Fennec. Splash screen is disabled by default, and mobile has to explicitly enable it, right?
Attachment #389087 - Flags: review?(benjamin) → review-
Attachment #389087 - Flags: review- → review?(benjamin)
Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]

As mentioned on IRC... We actually will be shipping Firefox (not Fennec) with a splashscreen for Windows CE. These will be different builds, including (among other tweaks) --enable-splashscreen.

Normal Windows (XP/Vista/etc) builds won't be affected, and will not have a splashscreen.
Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]

ok, with beltzner's approval
Attachment #389087 - Flags: ui-review?(beltzner)
Attachment #389087 - Flags: review?(benjamin)
Attachment #389087 - Flags: review+
Attachment #389087 - Flags: ui-review?(beltzner) → ui-review+
Pushed http://hg.mozilla.org/mozilla-central/rev/6004e947157b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Blocks: FF2SM
Blocks: 506217
No longer blocks: FF2SM
Verified fix on trunk and 192 branch.
Status: RESOLVED → VERIFIED
Summary: Add splashscreen support to build system → Add splashscreen support to build system, Firefox part
Attachment #389087 - Attachment description: Patch v.1 → Patch v.1 [Checkin: Comment 5]
Blocks: 653333
You need to log in before you can comment on or make changes to this bug.