504750 - Add splashscreen support to build system, Firefox part

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Justin Dolske [:Dolske]]

Bug 481494 added optional support for splash screens on slow devices, but didn't integrate with the build system for shipping the bitmap used.

This patch adds support for a splash.bmp in the build system that's used when a splashscreen is enabled. Bug 502526 will update the splash screens with polished artwork, this patch just includes the Firefox-branded splash vlad made (attached in 502526), and a couple placeholders for the unbranded and nightly branding.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1 [Checkin: Comment 5]

Now with more splash.

Comment 2

[Benjamin Smedberg]

Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]

We shouldn't ever be shipping Firefox with a splash screen, just Fennec. Splash screen is disabled by default, and mobile has to explicitly enable it, right?

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]

As mentioned on IRC... We actually will be shipping Firefox (not Fennec) with a splashscreen for Windows CE. These will be different builds, including (among other tweaks) --enable-splashscreen.

Normal Windows (XP/Vista/etc) builds won't be affected, and will not have a splashscreen.

Comment 4

[Benjamin Smedberg]

Comment on attachment 389087 [details] [diff] [review]
Patch v.1
[Checkin: Comment 5]

ok, with beltzner's approval

Comment 5

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/6004e947157b

Comment 6

[Tony Chung [:tchung]]

Verified fix on trunk and 192 branch.