504767 - add DLL build code for Symbian emulator

Status: RESOLVED WONTFIX

(NSPR :: NSPR, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: patch v0

- Remove --enable-symbian-target optiion.  This value can set by --target=xxx option
- Add DLL build option for Symbian emulator (WINSCW)
- Symbian emulator is not ARM.  So, sets correct value for OS_TEST and OS_ARCH.
- Add UID (this values are dummy now. After getting it by mozilla.org / mozilla.com, it sets correct value.)

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 389092 [details] [diff] [review]
patch v0

I'd like to get opinions from some of the other Symbian contributors.

Comment 2

[Harry Li]

For a quick response I had a quick look on patch v0, it is cool and it's much trickier than mine. I haven't used this in my machine cause I am on a biz travel now, then I could give just one question to patch v0. As we are going to build nspr DLLs for WINSCW, however in the new "symbian_uid.txt" file you only give 0x00000000 values for UID3, are those values just temporary place holders? If so, I think we could open a bug to maintain UIDs used in Fennec on Symbian OS, I just applied dozens last year.

And a small notice, after this patch landed, the situation for NSPR is it will be shared library for WINSCW(emulator) and still static library for ARM(device) build. Then we will move device build to shared library too.

Comment 3

[Harry Li]

Sorry, I haven't ready your comment in the initial bug submit, now I know they are dummy UID3.

Comment 4

[Makoto Kato [:m_kato]]

Although this patch is WIP, there is know issue.

- cross_compiling flag becomes no.  This will be fixed by next.
- pr*.h headers may conflict with S60 system and nspr.  This will be fixed by next.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 389092 [details] [diff] [review]
patch v0

I am canceling these review requests because the preceding comment tells us there will soon be a newer patch.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: patch v1

Comment 7

[Harry Li]

Here is a quick reply, I can build WINSCW DLLs with attachment 390769 [details] [diff] [review] successfully. Then I will test this on the emulator.

Comment 8

[Harry Li]

Attachment: test patch

With "patch v1" I could build emulator DLL successfully. And then I patched the Makefile.in in nsprpub/pr/tests to make test cases compiled and linked. I tested the result exes in the emulator with caller in bug 501172 attachment 387846 [details], the result is good. Now this patch is here as a draft asking for comment. There are some other issues not related with this patch itself, it will be talked later.

Comment 9

[Makoto Kato [:m_kato]]

Symbian is gone, so mark as WONTFIX.