version-bump.pl doesn't know how to bump comm-central branch version files

RESOLVED FIXED

Status

Release Engineering
General
--
major
RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 389108 [details] [diff] [review]
match any $(app)/config/version*.txt file

As comm-central allows both builds with a branch repository and mozilla-central, we have multiple $(app)/config/version*.txt files to state different versions based on the platform we are building with.
I just wanted to start the SeaMonkey 2.0b1 builds and the tag factory failed with version-bump.pl not knowing what the version-191.txt file is that we need to bump there.

The solution is to match any $(app)/config/version*.txt file in the part of version-bump.pl that determines in what way to bump that file.

I have tested that this patch works correctly with both version.txt and version-191.txt files and I need it ASAP to be able to build SeaMonkey 2.0 Beta 1.
Attachment #389108 - Flags: review?(bhearsum)
(Assignee)

Comment 1

9 years ago
Degrading to major as it's still a blocker for using release automation with the main build/tools repo but I ran SM2.0b1 build1 successfully with the patch on a cloned repo in seabld's private space and re-importing the verify-config changesets into build/tools.
Severity: critical → major
Attachment #389108 - Flags: review?(bhearsum) → review+
Comment on attachment 389108 [details] [diff] [review]
match any $(app)/config/version*.txt file

Looks fine to me. Feel free to land this anytime, and please add it to the Maintenance wiki page.
(Assignee)

Comment 3

9 years ago
Pushed as http://hg.mozilla.org/build/tools/rev/0da82dfb9dc5 - adding to the wiki now. Thanks.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.