Closed Bug 504837 Opened 15 years ago Closed 15 years ago

hashchange event should not be restricted to firing only when the document's ready state is "complete"

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

Patch for checkin v2
7.16 KB, patch
justin.lebar+bug
: review+
justin.lebar+bug
: superreview+
Details | Diff | Splinter Review 
The HTML5 spec has changed.  When we fixed bug 385434, the hashchange event was to be fired only when the document's ready state was "complete".  That restriction has now been removed, so we should update FF to conform to the spec.
Attached patch Proposed patch (obsolete) — — Splinter Review 

        Attachment #389162 -
        Flags: review?(Olli.Pettay)

        Attachment #389162 -
        Flags: superreview+

        Attachment #389162 -
        Flags: review?(Olli.Pettay)

        Attachment #389162 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  
Forwarding review from previous patch.

        Attachment #389162 -
        Attachment is obsolete: true

        Attachment #389554 -
        Flags: superreview+

        Attachment #389554 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
Landed:
http://hg.mozilla.org/mozilla-central/rev/a28347623d0f
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
  
Keywords: checkin-needed

    
    

    
  
We backed this out due to failing mochitests on Linux.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248135731.1248138667.27477.gz

http://hg.mozilla.org/mozilla-central/rev/a7af1507a5a9
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  


  
Previous patch for checkin didn't clean up the tests well, and we intermittently failed the tests when running a release build.  I think this patch gets rid of all the obsolete tests; it appears to consistently pass with release builds, and it passed on tryserver yesterday.

        Attachment #389554 -
        Attachment is obsolete: true

        Attachment #390065 -
        Flags: superreview+

        Attachment #390065 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
Pushed: http://hg.mozilla.org/mozilla-central/rev/f82a5ce4c3ce
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED

    
  
Keywords: checkin-needed
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: