Last Comment Bug 504870 - Consider removing tabbrowser.xml DOMWindowClose hack from bug 263844
: Consider removing tabbrowser.xml DOMWindowClose hack from bug 263844
Status: RESOLVED FIXED
fixed by bug 402147
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 4.0
Assigned To: Nobody; OK to take it and work on it
:
: Dão Gottwald [:dao]
Mentors:
http://hg.mozilla.org/mozilla-central...
Depends on: 402147
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-17 11:27 PDT by :Gavin Sharp [email: gavin@gavinsharp.com]
Modified: 2012-08-12 12:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description :Gavin Sharp [email: gavin@gavinsharp.com] 2009-07-17 11:27:49 PDT
The patch for bug 263844 ended up causing crashes when initially landed (bug 265790), so a followup fix was pushed to tabbrowser's DOMWindowClose handler to work around it (attachment 163514 [details] [diff] [review]).

I think that code is unnecessary now (the testcase in bug 265790 doesn't crash without it in Fennec), but we should make sure before removing it.

Note You need to log in before you can comment on or make changes to this bug.